you can run StompTest from eclipse or from the command line:

./build.sh integration-tests -Dtest-mask=StompTest

I found the issue.

I'm using Netty's DelimiterBasedFrameDecoder to "delimit" a Stomp frame. It uses a NUL 0x00 byte as a delimiter.

However this will not work if you have NUL byte in the Stomp body.

I'll have to rewrite the decoder to fix this and make sure that if there is a content-length header, we read all the length

before creating the frame.

Best to use the

public int isReadyToHandle(HornetQBuffer buffer);
  
void handleBuffer(RemotingConnection connection, HornetQBuffer buffer);

Methods on protocol manager to do this, instead of writing another framedecoder

timfox wrote:

 

Best to use the

 

public int isReadyToHandle(HornetQBuffer buffer);
  
void handleBuffer(RemotingConnection connection, HornetQBuffer buffer);

 

Methods on protocol manager to do this, instead of writing another framedecoder

that was my 1st idea but in this case, it will not be simple or efficient.

I need to decode the buffer as it goes to be able to check if it has a "content-length" header or not.

If it has one, I know how many other bytes I need before handling the buffer.

Otherwise, I'll continue to read it until I encounter the first NUL byte.

I'll have decoded almost all the frame to know if I can handle it.

At this point, it'd be simpler to work with the decoded frame and pass it directly to the StompProtocolManager rather

than use a HornetQBuffer with all the needed bytes and decode it a 2nd time.

Why would it be less efficient?

You have to read the buffer anyway to see if it's ready.

I don't follow your logic here

You have to write the decoding logic *anyway*, the question is whether that logic is in a FrameDecoder or in the ProtocolManager.

It's cleaner to put it in the ProtocolManager since then all the protocol specific code is in one place.

My point was that using HornetQFrameDecoder, I'd have to decode the Frame twice in the ProtocolManager:

   public int isReadyToHandle(HornetQBuffer buffer)
   {
      // decode almost all the frames to know its length
      return length;
   }

   public void handleBuffer(final RemotingConnection connection, final HornetQBuffer buffer)
   {
      // decode completely the frame a 2nd time 
      StompFrame frame = decode(buffer);
      // work with the frame
   }

Probably a better way to ask this question, is how would you write a FrameDecoder to do what you require?

BTW, this discussion should be on the dev forum