2 Replies Latest reply on May 12, 2010 2:11 AM by HuiSheng Xu

    discuss about how to finish el refactor job

    HuiSheng Xu Master

      Hi guys,

        I notice that Tom didn't finish his job for el refactor.  we could see these issues have not finished yet.

       

      https://jira.jboss.org/jira/browse/JBPM-2686

      https://jira.jboss.org/jira/browse/JBPM-2653

      https://jira.jboss.org/jira/browse/JBPM-1209

      https://jira.jboss.org/jira/browse/JBPM-2777

       

        Some of them were stay on Coding in progress for a long time.  And I think we should consider about them.  And find way to finish the job.

       

        At this moment, Tom has done lots of works for refactor el from jsr-223 to UEL.  I think he want to remove all of reference for ScriptManger from existing classes except ScriptActivity.  And he also said that we should deprecate the language attribute from expr, because after refactor job, the expr will always use UEL to evaluate the value from execution or task.

       

      So I think we could go through his work, let components use org.jbpm.pvm.internal.el.Expression to handle the expr.  Here is the which components are using ScriptManager:

      jBPM-4.3jBPM-4.4
      org.jbpm.bpmn.flownodes.ScriptTaskActivity.java
      org.jbpm.jpdl.internal.activity.AssignActivity.java
      org.jbpm.jpdl.internal.activity.DecisionExpressionActivity.java
      org.jbpm.jpdl.internal.activity.JmsActivity.javaorg.jbpm.jpdl.internal.activity.JmsActivity.java
      org.jbpm.jpdl.internal.activity.RulesFact.java
      org.jbpm.jpdl.internal.activity.ScriptActivity.javaorg.jbpm.jpdl.internal.activity.ScriptActivity.java
      org.jbpm.jpdl.internal.activity.ScriptBinding.javaorg.jbpm.jpdl.internal.activity.ScriptBinding.java
      org.jbpm.jpdl.internal.activity.SubProcessActivity.javaorg.jbpm.jpdl.internal.activity.SubProcessActivity.java
      org.jbpm.jpdl.internal.activity.SubProcessInParameterImpl.java
      org.jbpm.jpdl.internal.activity.SubProcessOutParameterImpl.java
      org.jbpm.jpdl.internal.activity.TaskActivity.java
      org.jbpm.pvm.internal.cal.Duration.java
      org.jbpm.pvm.internal.el.ScriptExpression.java
      org.jbpm.pvm.internal.email.impl.MailProducerImpl.javaorg.jbpm.pvm.internal.email.impl.MailProducerImpl.java
      org.jbpm.pvm.internal.job.TimerImpl.java
      org.jbpm.pvm.internal.model.ExecutionImpl.javaorg.jbpm.pvm.internal.model.ExecutionImpl.java
      org.jbpm.pvm.internal.model.ExpressionCondition.javaorg.jbpm.pvm.internal.model.ExpressionCondition.java
      org.jbpm.pvm.internal.model.VariableDefinitionImpl.java
      org.jbpm.pvm.internal.model.VariableOutDefinitionSet.javaorg.jbpm.pvm.internal.model.VariableOutDefinitionSet.java
      org.jbpm.pvm.internal.script.ScriptManager.javaorg.jbpm.pvm.internal.script.ScriptManager.java
      org.jbpm.pvm.internal.wire.binding.ScriptManagerBinding.javaorg.jbpm.pvm.internal.wire.binding.ScriptManagerBinding.java
      org.jbpm.pvm.internal.wire.descriptor.ExpressionDescriptor.javaorg.jbpm.pvm.internal.wire.descriptor.ExpressionDescriptor.java
      org.jbpm.pvm.internal.wire.descriptor.ObjectDescriptor.java

       

      We could see that some of them had been solved by Tom and Joram.  But there are still some components were not solved yet.  So I want to continue their jobs.  Anyone has any ideas?  Any reply is apprieciate.  Thank you very much.