1 Reply Latest reply on Dec 2, 2010 10:15 PM by Yong Hao Gao

    Large Message code review...

    Clebert Suconic Master

      Just removing the Thread that's not being used any longer



      I - LargeMessageCompressedTest: Instead of copy&pasting the LargeMessageTest.. it should be an extension. Just extend the original class, and change the createSessionFActory (or createConnector at the new method). Use some hook.. anything instead of copy & paste.

      II - I'm removing the thread pool method from the factory at your branch. You should make sure you don't commit any Thread related method at the factories.

      III - I need a little explanation why the method that inflates is called deflater and the deflater is called inflater (on the JDK :-) )...
      But everything looks great. I'm glad we have you helping us now :-)