unnecessary checkstyle rules, IMO
dward Feb 2, 2011 8:38 AMI really don't believe we need these checkstyle rules:
Message: Redundant 'public' modifier.
Flagged: public String getFoo();
Suggested: String getFoo();
Beef: I would rather my method signature on my interface reads exactly as it does in the implementation.
Message: ',' is not followed by whitespace.
Flagged: private Map<String,String> map;
Suggested: private Map<String, String> map;
Beef: I would rather have it more compact.
Message: '{' is not followed by whitespace.
Flagged: private Foo() {}
Suggested: private Foo() {
}
Beef: I would rather have it more compact.
PS: private constructors are useful for singletons or utility classes.
Message: '}' is not preceded with whitespace.
Flagged: private Foo() {}
Suggested: private Foo() {
}
Beef: I would rather have it more compact.
PS: private constructors are useful for singletons or utility classes.
Message: 'cast' is not followed by whitespace.
Flagged: B b = (B)a;
Suggested: B b = (B) a;
Beef: I would rather have it more compact.
Message: '=' is not preceded with whitespace.
Flagged: for (int i=0; i < length; i++)
Suggested: for (int i = 0; i < length; i++)
Beef: I would rather have it more compact.
Message: Name '_child_thing' must match pattern '^[a-z][a-zA-Z0-9]*$'.
Flagged: private Thing _child_thing;
Suggested: private Thing _childThing;
Beef: Who cares?
Message: '1024' is a magic number.
Flagged: StringBuffer buffer = new StringBuffer(1024);
Suggested: StringBuffer buffer = new StringBuffer();
Beef: Sometimes you want to set a buffer size for better performance.
Message: '1024' is a magic number.
Flagged: char[] c = new char[1024];
Suggested: int length = 1024; char[] c = new char[length];
Beef: Sometimes you want to set a buffer size for better performance.
Message: '+' is not preceded with whitespace
Flagged: return name.substring(pos+1, name.length());
Suggested: return name.substring(pos +1, name.length());
Beef: I would rather have it more compact.
Message: '+' is not followed by whitespace.
Flagged: return name.substring(pos+1, name.length());
Suggested: return name.substring(pos+ 1, name.length());
Beef: I would rather have it more compact.
Can we please get rid of them?