API thoughts

genman Apr 30, 2008 3:18 AM

VersionsReaderFactory should probably have a private constructor.

Not sure having a package "org.jboss.envers.exception" makes sense. Usually exceptions fall into the package that the exception is actually used in. At least, this is the JBoss convention I've seen so far.

1. Re: API thoughts

adamw Apr 30, 2008 5:18 AM (in response to genman)

Hello,

you're right about the factory, it should have a private constructor, and it now has.

And you're possibly also right about the exceptions package - that a class is an exception is already mentioned in its name, so there's really no need to put it in a package.

--
Adam
Actions