7 Replies Latest reply on Feb 23, 2011 7:28 AM by flaviohenrique

Richfaces 4 M6: second click in sortable header don´t work

flaviohenrique Feb 20, 2011 2:50 PM

I followed the showcase and now I am able to sort, BUT if I click twice, only the first click is processed. I also find a strange behavior. There are many calls to action="#{meuMB.sortByNome}" when the column header is clicked. I didn´t understand why this method must be void, since JSF action method allways return a String. By the way, I also tried to change this but the problem still occurs. This problem affected all browsers.

ManagedBean code related to sorting:

(...)

private SortOrder nomeOrder = SortOrder.unsorted;

public void sortByNome(){

if (this.nomeOrder.equals(SortOrder.ascending)) {

this.nomeOrder = SortOrder.descending;

} else {

this.nomeOrder = SortOrder.ascending;

}

Page code:

?xml version="1.0" encoding="UTF-8" ?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"

xmlns:h="http://java.sun.com/jsf/html"

xmlns:f="http://java.sun.com/jsf/core"

xmlns:a4j="http://richfaces.org/a4j"

xmlns:rich="http://richfaces.org/rich">

<h:head>

</h:head>

<h:body>

<h:form>

<rich:dataTable id="tabela" value="#{meuMB.pessoas}" var="pessoa" rows="5"

noDataLabel="Não há dados" sortMode="single">

<rich:column id="a1" sortBy="#{pessoa.nome}"

sortOrder="#{meuMB.nomeOrder}">

<f:facet name="header">

<a4j:commandLink value="Nome" render="tabela"

action="#{meuMB.sortByNome}" />

</f:facet>

<h:outputText value="#{pessoa.nome}" />

</rich:column>

<rich:column>

<f:facet name="header">

<h:outputLabel value="Idade" />

</f:facet>

<h:outputText value="#{pessoa.idade}" />

</rich:column>

<f:facet name="footer">

<rich:dataScroller />

</f:facet>

</rich:dataTable>

</h:form>

</h:body>

</html>

1. Richfaces 4 M6: second click in sortable header don´t work

ilya_shaikovsky Feb 21, 2011 4:29 AM (in response to flaviohenrique)

which scope the meuMB has? If request - sortOrder will be reseted for every request with that code.
1 of 1 people found this helpful
Actions
2. Richfaces 4 M6: second click in sortable header don´t work

flaviohenrique Feb 21, 2011 6:26 AM (in response to ilya_shaikovsky)

It´s in @ViewScoped. I also changed it to @SessionScoped and all behavior that I listed still present.

@ManagedBean
@ViewScoped
public class meuMB implements Serializable{
(...)

I am using Mojarra 2.0.4. I tried to downgrade to 2.0.3, but i got the same problem.
Actions
3. Richfaces 4 M6: second click in sortable header don´t work

jbalunas Feb 21, 2011 8:14 AM (in response to flaviohenrique)

We'll have to review this one asap to see if there is an issue here that might need to be addressed in Final. Ilya, can you create a jira, and assign for investigation?
Actions
4. Richfaces 4 M6: second click in sortable header don´t work

ilya_shaikovsky Feb 22, 2011 7:06 AM (in response to flaviohenrique)

Jus realized that the problem lies completelly at client side!(sorry but missed point about frequent clicks only and thought that the problem is common for any ones) And fortunatelly what is more good related to demo code!

So change render of the links to the tabela@body. As you have the tabela now - all the table getting rendered and links DOM elements became replaced also. That's why click event's from old instances getting lost also.

Checked that it started to work at showcase and I will updated demo correspondingly soon.
Actions
5. Richfaces 4 M6: second click in sortable header don´t work

flaviohenrique Feb 22, 2011 11:59 AM (in response to ilya_shaikovsky)

Ilya, maybe I am doing some wrong (JSF 1.0 is fine, but I also need to learn JSF 2.0), but I made the change you asked and still have the same problem.

   <f:facet name="header">
     <a4j:commandLink value="Nome" render="tabela@body"
      action="#{meuMB.sortByNome}" />
    </f:facet>

When I debug, multiples call to meuMB.sorByNome are fired, change to Ascend and Descend continuos.

I can´t see what is wrong with that code
Actions
6. Richfaces 4 M6: second click in sortable header don´t work

ilya_shaikovsky Feb 23, 2011 6:21 AM (in response to flaviohenrique)

When I debug, multiples call to meuMB.sorByNome are fired, change to Ascend and Descend continuos.
I'm sorry but seems I missing the point now... what's the problem with latest code?
Actions
7. Richfaces 4 M6: second click in sortable header don´t work

flaviohenrique Feb 23, 2011 7:28 AM (in response to ilya_shaikovsky)

I made the change you recommended render="tabela@body", but I still can´t get the second click on header sort the datatable.
Why? Because a single click on the sortable header makes multiples call to sorByNome() even in @ViewScoped or @SessionScoped.

The first click, even firing multiples calls, works, because nomeOrder starts with SortOrder.unsorted and became ascending, then, after the second click (yet multiples calls) anomeOrder still ascending (because of the last call), not descending.

As I undestood, you said that this behavior can happens if you do not go with @ViewScoped or @SessionScoped, but both are suffering from the same problem.
Actions

Go to original post