4 Replies Latest reply on Apr 6, 2011 3:36 AM by lfryc

a4j:commandButton, data called two times.

pechnik Apr 5, 2011 11:23 AM

I have h:form with a4j:commandButton in it. I use data property for calling bean method. When I press it my bean method calls several times.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<ui:composition xmlns="http://www.w3.org/1999/xhtml"
                xmlns:ui="http://java.sun.com/jsf/facelets"
                xmlns:f="http://java.sun.com/jsf/core"
                xmlns:h="http://java.sun.com/jsf/html"
                xmlns:rich="http://richfaces.org/rich"
                xmlns:a4j="http://richfaces.org/a4j">
    <rich:popupPanel id="add_new_trader_modal_panel" modal="true"
                     width="370" minWidth="370"
                     autosized="true" resizeable="false" moveable="true" >
        <f:facet name="header">
            <h:outputText value="Adding a new trader"
                          style="padding-right:20px;" />
        </f:facet>
        <h:form>
            <h:panelGrid columns="1" columnClasses="centerText"
                         cellspacing="3px" width="100%" >
                <h:outputText value="Type needed information about this trader: " />
                <hr width="100%" size="1px"/>
                <h:outputText value="" />
                <h:outputText value="" />
            </h:panelGrid>
            <h:panelGrid columns="2" cellspacing="3px"
                         columnClasses="indexes, values" width="100%" >
                <h:outputText value="Login name: " />
                <h:inputText value="#{TradersDataController.newTrader.name}"
                             maxlength="70" />
                <h:outputText value="Password: " />
                <h:inputText value="#{TradersDataController.newTrader.password}"
                             maxlength="70" /> 
            </h:panelGrid>
            <hr width="100%" size="1px"/>
            <h:outputText value="" />
            <h:panelGrid columns="2" width="100%" columnClasses="centerText, centerText" >
                <a4j:commandButton value="  Yes  "
                                   status="waitStatus"
                                   data="#{TradersDataController.doCreateTrader()}"
                                   oncomplete="if (data == 'Trader created successfully.') {Richfaces.hidePopupPanel('add_new_trader_modal_panel');} else {Richfaces.showPopupPanel('show_notification_add_trader');}"
                                   render="show_notification_add_trader, table_tr_wrapper"
                                   />
                <a4j:commandButton value="Cancel"
                                   status="waitStatus"
                                   action="#{TradersDataController.clearNewTrader}"
                                   onclick="#{rich:component('add_new_trader_modal_panel')}.hide();return false;" />
            </h:panelGrid>
        </h:form>
    </rich:popupPanel> 
</ui:composition>

What is wrong? And what method can be used instead of Richfaces.showModalPanel?

1. Re: a4j:commandButton, data called two times.

lfryc Apr 5, 2011 1:20 PM (in response to pechnik)

Hello Bronislav,

it seems you are misusing @data attribute, see reference [1].

You use method binding in @data attribute and it is not satisfied that it will be evaluated only once.

You should consider to cache the result of doCreateTrader() in backing bean and use @action instead, something like:

@RequestedScoped
@ManagedBean
public class TraderBacking() {

     @ManagedProperty(name="#{TradersController}")
     TradersController tradersController;

     private boolean created = false;

     public void createTrader() {
          try {
               String result = tradersController.doCreateTrader();
               if ("Trader created successfully.".equals(result)) {
                    created = true;
               }
          } catch (Exception e) {
               log(e);
          }
     }

     public void isCreated() {
          return created;
     }
}

[1] http://docs.jboss.org/richfaces/4.0.X/4.0.0.Milestone6/Component_Reference/en-US/html/chap-Component_Reference-Common_Ajax_attributes.html#sect-Component_Reference-Events_and_JavaScript_interactions-data

2. Re: a4j:commandButton, data called two times.

lfryc Apr 5, 2011 1:23 PM (in response to lfryc)

You can also use #{rich:component('add_new_trader_modal_panel')}.show()
Actions
3. Re: a4j:commandButton, data called two times.

pechnik Apr 5, 2011 1:50 PM (in response to lfryc)

The problem of first call is that, no data was puted into the bean. In the second call they are in the bean.
Who is called first @action or @data ?
Actions
4. Re: a4j:commandButton, data called two times.

lfryc Apr 6, 2011 3:36 AM (in response to pechnik)

@action/@actionListener is called first and should trigger business logic.
Then @data is obtained and sent to client.

(If you will try to debug code, @data is accessed several times, once even before @action is performed, but the final invocation obtaining data for sending to client is done after @action).
1 of 1 people found this helpful
Actions

Go to original post