9 Replies Latest reply on Oct 19, 2009 4:34 AM by lat3

    MenuGroup in DropDownMenu

    nfeybesse

      Hi,

      It seems there is a regression between 3.3.2 GA and 3.3.2 SR1.

      In 3.3.2 SR1, my menu is displayed out of the borders of the frames.

      Could you check on your demo with 3.3.2 SR1 ?

      http://livedemo.exadel.com/richfaces-demo/richfaces/dropDownMenu.jsf?c=dropDownMenu&tab=usage

      I can't do that because the demo is still in version 3.3.2.GA.

      Thanks in advance

      NF

        • 1. Re: MenuGroup in DropDownMenu
          nbelaevski

          Hi,

          Works ok for me. Can you please add screenshot and browser information?

          • 2. Re: MenuGroup in DropDownMenu
            ilya_shaikovsky

             

            I can't do that because the demo is still in version 3.3.2.GA.


            thanks for that report. will be corrected. :)

            About issue.. we checked richfaces-demo 3.3.2 SR1 locally and can't see the problem so please add your code snippets and share screenshot.

            • 3. Re: MenuGroup in DropDownMenu

              Hi,

              I work with nfeybesse, and here is what we have :

              http://img337.imageshack.us/img337/9350/dropdown.png
              http://img337.imageshack.us/img337/9045/dropdown2.png

              The menu should appear under the "options" button when the latter has been clicked, but it appears outside of the borders of the frame.

              Also note that the submenu shown in the first screenshot is absolutely placed where it should, whereas the submenu shown in the second screenshot is relatively placed where it should, which puzzles me.

              here is the code of the dropdown menu. The "options" button is in a rich:toolbar element, but I've tried moving it out, and it didn't change anything.

              <rich:dropDownMenu>
               <f:facet name="label">
               <h:outputText value="Options" />
               </f:facet>
              
               <rich:menuGroup value="#{messages.Language}">
               <c:forEach var="locale" items="#{localeSelector.supportedLocales}">
               <rich:menuItem value="#{locale.label}"
               iconDisabled="#{infos.imgNavigateRight}"
               disabled="#{localeSelector.localeString eq locale.value}"
               immediate="true" ajaxSingle="true"
               actionListener="#{localeSelector.setLocaleString(locale.value)}"
               action="#{localeSelector.select}" />
               </c:forEach>
               </rich:menuGroup>
              
               <rich:menuGroup value="#{messages.SelectDatePattern}">
               <c:forEach var="pattern" items="#{calendarBean.patterns}">
               <rich:menuItem submitMode="ajax" value="#{pattern.label}"
               iconDisabled="#{infos.imgNavigateRight}"
               disabled="#{calendarBean.currentDatePattern eq pattern.value}"
               immediate="true" ajaxSingle="true"
               actionListener="#{calendarBean.setCurrentDatePattern(pattern.value)}"
               action="application" />
               </c:forEach>
               </rich:menuGroup>
              
               <rich:menuGroup value="#{messages.administrationSkins}">
               <c:forEach var="theme" items="#{themeSelector.themes}">
               <rich:menuItem submitMode="ajax" value="#{theme.label}"
               iconDisabled="#{infos.imgNavigateRight}"
               disabled="#{themeSelector.theme eq theme.value}" immediate="true"
               ajaxSingle="true"
               actionListener="#{themeSelector.setTheme(theme.value)}"
               action="#{themeSelector.select}" />
               </c:forEach>
               </rich:menuGroup>
              
               </rich:dropDownMenu>
              


              Also, I've compared the source code of the page generated with 3.3.2.GA with the one obtained under 3.3.2.SR1 and the only difference is a
              <div class="rich-mpnl_panel">
              that becomes a
              <div class="rich-mpnl-panel">
              (with an underscore instead of a dash). Could this be related ? There has been a change on the modalpanel in SR1, and I wouldn't be too surprised if it had impacted the dropdownmenu given that they both are some sorts of "popups".

              Thanks for your help anyway

              • 4. Re: MenuGroup in DropDownMenu
                ilya_shaikovsky

                not css change should not be related to this. because new class contains fully the same props.

                Please try firebug to check styles applied. Maybe some your classes overrides some our properties?

                • 5. Re: MenuGroup in DropDownMenu

                  I've digged a little deeper. Css is not involved. It's the disabled tag of a menuItem that causes the problem. You could try the following example to convince yourself of the problem.


                  <rich:dropDownMenu>
                   <f:facet name="label">
                   <h:outputText value="titi" />
                   </f:facet>
                   <rich:menuGroup value="bob">
                   <rich:menuItem value="bob1" />
                   <rich:menuItem value="bob2" disabled="true"/>
                   <rich:menuItem value="bob3" />
                   <rich:menuItem value="bob4" />
                   </rich:menuGroup>
                   <rich:menuGroup value="toto">
                   <rich:menuItem value="toto1" />
                   <rich:menuItem value="toto2" />
                   <rich:menuItem value="toto3" />
                   </rich:menuGroup>
                   <rich:menuItem value="coucou" />
                   </rich:dropDownMenu>
                  


                  Thanks for your time

                  • 6. Re: MenuGroup in DropDownMenu
                    ilya_shaikovsky
                    • 7. Re: MenuGroup in DropDownMenu
                      ilya_shaikovsky

                      thanks for your report!

                      • 8. Re: MenuGroup in DropDownMenu
                        ilya_shaikovsky

                        seems we have no workaround unfortunatelly. So you have two ways

                        1) use 3.3.3 SNAPSHOT after will be fixed
                        2) if you can use stable releases only - could workaround this by emulating disabled instead of attribute usage. (css class and submitMode="none" or onclick=return false;)

                        • 9. Re: MenuGroup in DropDownMenu

                          Ok, thanks for the tips...