SHRINKWRAP-99 ExplodedExporter and Filesystem conflicts

alrubinger Dec 4, 2009 9:32 PM

https://jira.jboss.org/jira/browse/SHRINKWRAP-99:

"The contract for ExplodedExporter should be documented to state what happens if there is an already existing target directory.

"Overwriting an existing directory without deleting all content first can cause problems."

The more overarching question here is: what behaviour should we take?

I'll kick off discussion with:

1) Recursively delete all content in the specified file first
2) Allow the archive to overlap with the current File if it exists, throwing an exception only if an Asset needs to overwrite an existing file
3) Throw a descriptive error to the user if the File they've specified both exists and has children

My preference for 3 as it fails the fastest and most reliably.

S,
ALR

1. Re: SHRINKWRAP-99 ExplodedExporter and Filesystem conflicts

aslak Dec 5, 2009 6:53 AM (in response to alrubinger)

I doubt we will find one way that fits all needs, but as part of https://jira.jboss.org/jira/browse/SHRINKWRAP-88 we could add methods like:

Exporter.overwrite().export() / delete overwrite everyting
Exporter.export() / fail on existing resources

?
Actions
2. Re: SHRINKWRAP-99 ExplodedExporter and Filesystem conflicts

alrubinger Dec 5, 2009 5:48 PM (in response to alrubinger)
I like the user choice angle.

Does this read more naturally:

Exporter.export(ExportMode.OVERWRITE); Exporter.export(ExportMode.OVERLAP); Exporter.export(ExportMode.REQUIRES_NEW); Exporter.export(); // Default to REQUIRES_NEW

...?

S,
ALR
Actions
3. Re: SHRINKWRAP-99 ExplodedExporter and Filesystem conflicts

jesper.pedersen Dec 7, 2009 9:33 AM (in response to alrubinger)
What is the use-case for OVERLAP ?

I would just keep it simple:

ZipExporter.export() ZipExporter.export(boolean delete) ExplodedExporter.export(File parent) ExplodedExporter.export(File parent, boolean delete)

and have "delete" default to false.
Actions

Go to original post