1 Reply Latest reply on Dec 4, 2008 5:04 PM by Dan Allen

    More possible bugs in many places

    Francisco Jose Peredo Noguez Master

      Here are some more bugs I am worried about (checking for nulls too late):


      Nullcheck of chart at line 144 of value previously dereferenced in org.jboss.seam.pdf.ui.UIChartSeries.encodeEnd(FacesContext)     jboss-seam/src
      



      and (again checking for nulls too late)


      Nullcheck of SpringTaskExecutorDispatcher.scheduleDispatcher at line 64 of value previously dereferenced in org.jboss.seam.ioc.spring.SpringTaskExecutorDispatcher.getScheduleDispatcher()     jboss-seam/src/ioc/org/jboss/seam/ioc/spring     
      



      and (what is the point of if (component == null !(component instanceof SpringComponent)) ?


      instanceof will always return true in org.jboss.seam.ioc.spring.SeamComponentPostProcessor.postProcessAfterInitialization(Object, String), since all org.jboss.seam.ioc.spring.SpringComponent are instances of org.jboss.seam.ioc.spring.SpringComponent     jboss-seam/src/ioc/org/jboss/seam/ioc/spring
      



      and (again what is the poing of if (facet instanceof UIComponent) if getFacet("header") always returns a UIComponent )


      instanceof will always return true in org.jboss.seam.pdf.ui.UIDocument.processHeaders(), since all javax.faces.component.UIComponent are instances of javax.faces.component.UIComponent     jboss-seam/src/pdf/org/jboss/seam/pdf/ui
      



      and this one left me speechless:


      Method org.jboss.seam.mail.ui.context.MailResponseWriter.write(String) uses the same code for two branches     jboss-seam/src/mail/org/jboss/seam/mail/ui/context
      



      And many others that I will post later, I will happly create a JIRA for each one, and a patch for each one. Shoud I do that?