7 Replies Latest reply on Feb 4, 2009 8:03 PM by Vladimir Kovalyuk

    Please fix JBSEAM-3645

    Vladimir Kovalyuk Apprentice

      Seam contributors, I'like to draw your attention to JBSEAM-3645. Since JBSEAM-3645 is not planned for any release, I can't suppose that it will be fixed soon.


      Someone who uses JSF wants to start using Wicket. Someone who uses Wicket wants to employ Seam to get its advantages. They can't do that right now unless patching seam.


        • 1. Re: Please fix JBSEAM-3645
          Clint Popetz Apprentice

          The issue underyling this issue is pretty complicated, as you can see from the patch.  I need to get another seam core committer to review it to ensure it's correct, and that takes time.


          A question: if there were a branch in seam for wicket work, so that you could build from this branch without patching, would you use it?  Another seam committer has suggested this, but I am not certain that it's worth the effort of maintaining the branch.  So  if anyone would build from svn on a branch with wicket-specific changes, please chime in.

          • 2. Re: Please fix JBSEAM-3645
            Vladimir Kovalyuk Apprentice

            I'm concerned about the fact that this issue hasn't been planned for any release. It means for me that it has been out of the Seam scope up to now. It does not matter how we apply your patch for now. It matters how can we plan to use it in the production. (actually we can't).


            From my perspective Seam suffers from lack of Wicket/JSF interoperability. If your patch solves the problem but is not considered to be the best approach from their point of view it is still the only patch and should be applied to SVN with comments. Also the new ticket should be created (with all the concerns about your patch) and planned to re-visit this functionality in the future.


            Even in current situation any reference to some valuable committer should be reflected in JIRA. I believe he/she should be assigned to the issue. That's the way JIRA is supposed to be employed into the process.


            Two fields should be filled in correctly: assignee and fix version.

            • 3. Re: Please fix JBSEAM-3645
              Clint Popetz Apprentice

              Vladimir Kovalyuk wrote on Feb 04, 2009 17:55:


              I'm concerned about the fact that this issue hasn't been planned for any release. It means for me that it has been out of the Seam scope up to now. It does not matter how we apply your patch for now. It matters how can we plan to use it in the production. (actually we can't).


              I can't place an expected fix version on the issue because I can't know, until reviewed, whether the solution is appropriate, and I can't know, if it's not appropriate, whether an alternative solution could be found in the timeline of any given release.  This ambiguity should be cleared up within a few weeks.



              From my perspective Seam suffers from lack of Wicket/JSF interoperability. If your patch solves the problem but is not considered to be the best approach from their point of view it is still the only patch and should be applied to SVN with comments.


              The problem is that if the patch is incorrect in any way, it could be detrimental to the stability of seam as a whole, regardless of whether people are using wicket, and this is unacceptable.



              Even in current situation any reference to some valuable committer should be reflected in JIRA. I believe he/she should be assigned to the issue. That's the way JIRA is supposed to be employed into the process.


              Assigning to another committer won't make the review happen any quicker.  I am in communication with other seam developers regarding the issue, and it will be addressed.  That's the best I can do.


              I assume that creating a wicket branch is not a solution to your needs, nor is building from patched source. Anyone else have thoughts on that?


              • 4. Re: Please fix JBSEAM-3645
                Vladimir Kovalyuk Apprentice

                My concerns about planning are adressed to Seam core team rather you. And I still believe it should has been done.




                The problem is that if the patch is incorrect in any way, it could be detrimental to the stability of seam as a whole, regardless of whether people are using wicket, and this is unacceptable.

                I agree. One should decide that the patch architecturally doesn't conflict with the other functionality.


                I'm afraid SVN branch won't give me early access to commits of enhancements, improvements and bugfixes in trunk unless you perform continuous integration with the trunk which I would consider as too big effort to be worthy.

                • 5. Re: Please fix JBSEAM-3645
                  Pete Muir Master

                  You're free to assign it to me and set the fix date to the future, but that won't actually make anything happen.

                  • 6. Re: Please fix JBSEAM-3645
                    Vladimir Kovalyuk Apprentice

                    My main intention was to push this issue forward. You said the process is not frozen and it is fine. Looking forward for updates.

                    • 7. Re: Please fix JBSEAM-3645
                      Vladimir Kovalyuk Apprentice

                      Pete, it will let me hope :)