This content has been marked as final.
Show 4 replies
-
1. Re: JournalLargeServerMessage copy
timfox Oct 25, 2009 4:02 AM (in response to timfox)Also... it's opening a new file for each large message that is copied?
Surely, you'll run out of file handles doing this? -
2. Re: JournalLargeServerMessage copy
timfox Oct 25, 2009 5:01 AM (in response to timfox)Another thing I don't understand about this - why is it incrementing the ref count?
-
3. Re: JournalLargeServerMessage copy
clebert.suconic Oct 26, 2009 12:05 PM (in response to timfox)That's using the same file name, but a different File Handler thourgh SequentialFile.
The increment is to avoid deleting the linkedMessage. So, the copied Message will be holding a reference until the message is also dereferenced. (on that case the original file will be deleted later).
Look at JournalLargeServerMessage::decrementReference:if (linkMessage != null) { // This file is linked to another message, deleting the reference where it belongs on this case linkMessage.decrementRefCount(); }
-
4. Re: JournalLargeServerMessage copy
clebert.suconic Oct 26, 2009 12:06 PM (in response to timfox)"timfox" wrote:
Also... it's opening a new file for each large message that is copied?
Surely, you'll run out of file handles doing this?
That was an accident. I'm removing the file.open();