3 Replies Latest reply on Nov 5, 2009 2:09 PM by clebert.suconic

    Producer flow control on LargeMessage

    clebert.suconic
    clebert.suconic Nov 4, 2009 3:59 PM

      Producer flow control used to be done at the Channel level.

      That used to mean.. as the client was putting packets on the wire, it would block until it has some window available.

      With the recent changes, if you send a 4GiB message, the client could overflow the channel. We need to take credits on each individual packet send. Otherwise you could more data array in memory waiting to be executed at some points.

      The LargeMessage example is currently broken because of that. (Set a big file size, and it will fail).

      https://jira.jboss.org/jira/browse/HORNETQ-206

      • 1958 Views
      • Tags:
        • 1. Re: Producer flow control on LargeMessage
          timfox
          timfox Nov 5, 2009 3:43 AM (in response to clebert.suconic)

          I fixed this, and now it works with 256MiB message.

          However there seems to be a problem with the large message buffer. If you increase the message size to 2 GiB, you get the following:

           [java] java.lang.IndexOutOfBoundsException
 [java] at org.hornetq.core.client.impl.LargeMessageBufferImpl.checkForPacket(LargeMessageBufferImpl.java:1266)
 [java] at org.hornetq.core.client.impl.LargeMessageBufferImpl.resetReaderIndex(LargeMessageBufferImpl.java:696)
 [java] at org.hornetq.jms.client.HornetQMessage.doBeforeReceive(HornetQMessage.java:1064)
 [java] at org.hornetq.jms.client.HornetQMessageConsumer.getMessage(HornetQMessageConsumer.java:218)
 [java] at org.hornetq.jms.client.HornetQMessageConsumer.receive(HornetQMessageConsumer.java:133)
 [java] at org.hornetq.jms.example.LargeMessageExample.runExample(LargeMessageExample.java:150)
 [java] at org.hornetq.common.example.HornetQExample.run(HornetQExample.java:73)
 [java] at org.hornetq.jms.example.LargeMessageExample.main(LargeMessageExample.java:45)


            • Actions
          • 2. Re: Producer flow control on LargeMessage
            timfox
            timfox Nov 5, 2009 10:45 AM (in response to clebert.suconic)

            https://jira.jboss.org/jira/browse/HORNETQ-208

              • Actions
            • 3. Re: Producer flow control on LargeMessage
              clebert.suconic
              clebert.suconic Nov 5, 2009 2:09 PM (in response to clebert.suconic)

              I couldn't replicate this failure.

              I have been all the way up to 10GiB, and it runs fine.

              I have seen memory warning on the server side though. (since the example plays with a 50MiB Server).

              Maybe I should clean up the buffer on the packets after received, since the packet still in memory when the credit is confirmed?

              I believe also the server will hold packets up to confirmation when delivering to the client.

              Maybe you had an OME during the transmission what caused an issue?

                • Actions