-
1. Re: ConsumerWindowSizeTest::testNoWindowRoundRobin is bogus?
clebert.suconic Nov 5, 2009 8:26 AM (in response to timfox)I thought I had already commented out the method.
But it was using the promptDelivery thread on purpose. I remember this was another thing we discussed back then. As long as flow control would give up delivery.
If we deliver it in another thread, we can't guarantee order also. You will be delivering another message before the previous message was completed. -
2. Re: ConsumerWindowSizeTest::testNoWindowRoundRobin is bogus?
timfox Nov 5, 2009 8:36 AM (in response to timfox)"clebert.suconic@jboss.com" wrote:
If we deliver it in another thread, we can't guarantee order also. You will be delivering another message before the previous message was completed.
How did you reach that conclusion? -
3. Re: ConsumerWindowSizeTest::testNoWindowRoundRobin is bogus?
clebert.suconic Nov 5, 2009 8:57 AM (in response to timfox)Say, you sent 100 LargeMessages. There are 100 Consumers.
You will have all the 100 Consumers receiving the message almost immediately. First: You could flood the server here, having too many packets on the Channel waiting to be delivered.
Also, the second message will be delivered before the previous one was finished.
Those are the two reasons why the delivery of the large message was done inside the promptDelivery thread until it was out of credits. -
4. Re: ConsumerWindowSizeTest::testNoWindowRoundRobin is bogus?
timfox Nov 5, 2009 9:02 AM (in response to timfox)"clebert.suconic@jboss.com" wrote:
Say, you sent 100 LargeMessages. There are 100 Consumers.
You will have all the 100 Consumers receiving the message almost immediately. First: You could flood the server here, having too many packets on the Channel waiting to be delivered.
Also, the second message will be delivered before the previous one was finished.
Those are the two reasons why the delivery of the large message was done inside the promptDelivery thread until it was out of credits.
I have no idea what you are talking about here. -
5. Re: ConsumerWindowSizeTest::testNoWindowRoundRobin is bogus?
clebert.suconic Nov 5, 2009 9:15 AM (in response to timfox)never mind: I was thinking about a scenario where you could flood the server.
Say, you send 100 messages. You could have 100 messages being delivered simultaneously consuming resources on the server.
But the Session executor is a thread pool, so that's not problem. -
6. Re: ConsumerWindowSizeTest::testNoWindowRoundRobin is bogus?
timfox Nov 5, 2009 9:23 AM (in response to timfox)Not only is it a thread pool, it is an ordered executor too, so I don't think any of your assertions hold water.