0 Replies Latest reply on Nov 5, 2009 9:33 AM by Tim Fox

    Refactor and clean up of paging code

    Tim Fox Master

      I have done a refactoring and clean-up of the paging code, including:

      ServerMessage now stores a reference to the paging store, so the continuous use of pagingManager.getPageStore(address) is no longer necessary. This saves a lot of ugly HashMap lookups.

      I have also removed the page and isPaging methods from PagingManager.

      There were quite a few public methods on PagingStore which were only called internally - they have been made private.

      Various other reformatting, tweaking etc.

      This code is significantly cleaner and clearer now.

      There are two tests failing in PagingStoreImpl test, not sure if the test is bogus or not.