I have talked to Tim.
Trustin was supposed to commit that decoder on the Optimization's branch. (not on trunk).
So, I have reverted it for now. You guys (Tim and Trustin) will have to replace it later.
Just for the record, I don't know if you guys want to apply those changes or not...
But NettyConsumerWindowSizeTest was *sometimes* taking 10 minutes to complete if you used the new encoder.
(yes.. I said it right... 10 minutes)
It's working fine after reverting it.
Apologies. That is weird. It seemed to work just fine. I will take a look again soon before Tim merges the branch.
The behavior of the original HornetQFrameDecoder has been changed:
The decoder in the trunk generates a frame without the length field, while Tim's modification includes the length field. That was why my new decoder was not working in trunk.
Which behavior is correct?
So, the new decoder was supposed to work only with the optimization branch and it was checked in to trunk (i.e. wrong branch). It seems to work fine with the optimization branch so far.