2 Replies Latest reply on Dec 3, 2009 5:24 AM by timfox

    Packet confirmation...

    clebert.suconic
    clebert.suconic Dec 3, 2009 2:00 AM

      There was a bug on the ReplicationEndpointImpl, and on ReplicationManagerImpl::ResponseHandler.


      I *though* confirmation was done automatically at ChannelImpl and I just saw it looks like it is explicit (as I looked on the other Handlers).


      So, I'm adding the confirmation now. Please let me know if I"m mistaken.

      • 1941 Views
      • Tags:
        • 1. Re: Packet confirmation...
          timfox
          timfox Dec 3, 2009 5:11 AM (in response to clebert.suconic)

          I don't understand what you're doing here.

          The reason we maintain packets for replay in the channel is so we can do reattach of clients to servers, this only occurs if confirmation-window-size is <> -1

          Reattachment only applies to client-server connections. Why would you want to do this on the live-backup replicating connection too?

            • Actions
          • 2. Re: Packet confirmation...
            timfox
            timfox Dec 3, 2009 5:24 AM (in response to clebert.suconic)

            I've removed the param backup-window-size and backup channel now has window size of -1.

            You would normally need to confirm each packet if you're using confirmations, but since I have set this to -1 the confirm() calls are unnecessary too.

            BTW setting backup-window-size to > 0 was pointless anyway since you had set reconnectAttempts to zero, also since you weren't confirming, packets would have built up for ever and you'd have got OOM eventually.

              • Actions