-
15. Re: JBoss AS 7.1.1 Final XA datasources memory leak
jbertram Sep 17, 2012 11:28 AM (in response to didier2011)Whenever the issue is fixed it will be committed to the community project and that will be the basis for the patch that is created for JBoss EAP. If you need this fix in your environment which is running JBoss AS 7.1.1 then you'll need to pull the source and build it yourself.
-
16. Re: JBoss AS 7.1.1 Final XA datasources memory leak
tomjenkinson Sep 17, 2012 4:28 PM (in response to jbertram)Hi,
My apologies, it looks like JBTM-895 seems to have removed some protection Jonathan has added, I am currently reinstating this. I have raised https://issues.jboss.org/browse/JBTM-1255 to track this as a Blocker on 4.17 (targetted at EAP 6.1).
Thanks,
Tom -
17. Re: JBoss AS 7.1.1 Final XA datasources memory leak
tomjenkinson Sep 18, 2012 10:33 AM (in response to tomjenkinson)I just thought I would keep folks in the loop.
Around 5 hrs ago I put back r38183 into https://svn.jboss.org/repos/labs/labs/jbosstm/branches/JBOSSTS_4_16 which should revert the issue for the branch of JBTM you are on. Although it works fine locally we will wait for our CI cluster to give us the all clear before marking https://issues.jboss.org/browse/JBTM-1255 as resolved. Here is the diff: https://source.jboss.org/changelog/JBossTransactions?cs=38183
After CI completes and you are notified of the fix, there are several options open to you.1. If you have a support contract you will no doubt have already in parallel raised a ticket, if you can reference the JBTM jira above, it should expedite any solution that can be offered.
2. Alternatively, if you are working in the community, you are free to adopt this patch however you like, e.g. build it and patch your own jar in AS or wait for an AS with it in. Do be advised that 4.16.5 and greater (of which this Jira composes part of) is unlikely to be adoped by an AS build for several weeks. Our current plan is to get 4.17.0 into AS 7.2.0 but I do not know for sure when that version of the AS is due. In the mean time, if you want to see how the JBTM team create an AS with the current version of JBTM in it, take a look at (or use): https://anonsvn.jboss.org/repos/labs/labs/jbosstm/branches/JBOSSTS_4_16/scripts/hudson/narayana.sh.
If you intend to build 4.16.5.Final-SNAPSHOT locally and want to build an AS with it in, you can see in narayana.sh the steps are roughly (pseudo code):
1. Build JBTM as normal from https://svn.jboss.org/repos/labs/labs/jbosstm/branches/JBOSSTS_4_16
2. git clone --tags git://github.com/jbossas/jboss-as.git
3. git remote add jbosstm git@github.com:jbosstm/jboss-as.git
4. git fetch jbosstm
5. git checkout -b 7.1.2.Final_with_jbossts-4.16.5-SNAPSHOT 7.1.2.Final
6. git cherry-pick 638584e68081a416ee2c479f380cdbed5e24ddbd
7. Build AS7 as normal
Clearly at some point we will release a 4.16.5 and then you won't need to use -SNAPSHOT as above.
I will update you when CI completes,
Tom
-
18. Re: JBoss AS 7.1.1 Final XA datasources memory leak
tomjenkinson Sep 19, 2012 2:34 AM (in response to tomjenkinson)Just to confirm, CI worked for this so please see my previous note for more details
-
19. Re: JBoss AS 7.1.1 Final XA datasources memory leak
karl_zhang Sep 19, 2012 12:11 PM (in response to tomjenkinson)Dear Tom,
thank you for the quick solution. I still want to ask you about the build process. If AS 7.1.2.Final with 4.16.5-SNAPSHOT want to be built, dose the AS 7.1.2.Final checked out in step 5 already contain 4.16.5-SNAPSHOT? If that is the case, step 1 is not needed anymore.
Could you please also confirm, if I did it correctly to build JBoss AS 7.1.1.Final:
1. build jbossts 4.16.5.Final-SNAPSHOT
- svn checkout http://anonsvn.jboss.org/repos/labs/labs/jbosstm/branches/JBOSSTS_4_16
- cd JBOSSTS_4_16
- ant -Demma.enabled=false -Dpublican=false -DskipTests=true
2. build jbossas with 4.16.5.Final-SNAPSHOT
- git clone git://github.com/jbosstm/jboss-as.git
- cd jboss-as/
- git checkout 7.1.1.Final
- change the version of jbossts related modules in pom.xml from 4.16.2.Final to 4.16.5.Final-SNAPSHOT
<version.org.jboss.jbossts.jbossjts>4.16.2.Final</version.org.jboss.jbossts.jbossjts>
<version.org.jboss.jbossts.jbossjts-integration>4.16.2.Final</version.org.jboss.jbossts.jbossjts-integration>
<version.org.jboss.jbossts.jbossxts>4.16.2.Final</version.org.jboss.jbossts.jbossxts>
- ./build.sh clean install -DskipTests
Best Regards,
Karl Gross
-
20. Re: JBoss AS 7.1.1 Final XA datasources memory leak
tomjenkinson Sep 19, 2012 1:35 PM (in response to karl_zhang)Hi Karl,
Step 5 is just git syntax to create a named branch. If should be noted that my flow builds the next EAP version, rather than 7.1.1. Your steps look good to me to get a 7.1.1 build with JBTM 4.6.5 in it.
You can tell if it worked by looking in <JBOSS_SRC_ROOT>/build/target/jboss-as-7.1.1.Final/modules/org/jboss/jts/main/,i n there will be jbossjts-4.16.5.Final-SNAPSHOT.jar
Hope that clarifies!
Tom
-
21. Re: JBoss AS 7.1.1 Final XA datasources memory leak
karl_zhang Sep 20, 2012 3:08 AM (in response to tomjenkinson)Hi Tom,
thank you for the clarification. I have checked the resulted jboass-as-7.1.1.Final, the jbossjts module has the version 4.16.5.Final-SNAPSHOT.
Best Regards,
Karl
-
22. Re: JBoss AS 7.1.1 Final XA datasources memory leak
tomjenkinson Sep 20, 2012 3:21 AM (in response to karl_zhang)Thats great, hope this resolves the leak for you.