Hibernate Envers refactoring.

vyacheslav86 Oct 2, 2012 5:33 AM

I've done some refactoring of envers to improve perfomance, design, and abstract it from hibernate. As a result of design improvement i've found about 5 errors.

I refactor to IoC, GoF patterns to abtract envers from hibernate and receive code with design patterns.

I wonder are you guys interested in pull request of such design improveming refactoring and if so can my name be added to authors list?

If so ill implement it in a month.

1. Re: Hibernate Envers refactoring.

vyacheslav86 Oct 10, 2012 6:40 AM (in response to vyacheslav86)

Or you interested in communication in a form of functional/integration test and code fixing it? Anyway if i commit code which fixes the bug can my name be added to source code file "@author" list?
Actions
2. Re: Hibernate Envers refactoring.

adamw Oct 10, 2012 3:12 PM (in response to vyacheslav86)

Sorry, I didn't look in the forum for a while.

Sure, that sounds very interesting! I guess such a refactoring would have to be applied step-by-step. Let me also check with Łukasz, maybe you could work together.

If you change any code, of course you can add yourself to @authors. You'll have to sign the CLA for Hibernate, though: https://cla.jboss.org/index.seam

Adam
Actions
3. Re: Hibernate Envers refactoring.

lukasz.antoniak Oct 12, 2012 6:43 AM (in response to adamw)

Definitely you should be listed as @author :). This way community is able to contact you regarding issues in the code or suggest improvements.
What I would suggest is just to leave a short explanation why certain pattern is used, this way we spend less time on reverse-engineering. Feel free to contact me directly.
Actions
4. Re: Hibernate Envers refactoring.

vyacheslav86 Oct 12, 2012 6:46 AM (in response to lukasz.antoniak)

Ok. I'll contact as fast as first patch will be ready.
Actions

Go to original post