5 Replies Latest reply on Oct 19, 2012 11:18 AM by Clebert Suconic

    volunteer to reformat the branches...

    Clebert Suconic Master

      We need a volunteer to reformat the 3 branches to the new coding style, add checkstyle to master and these 2 branches and reconfigure eclipse / idea.

       

       

      Any volunteer?

        • 1. Re: volunteer to reformat the branches...
          Andy Taylor Master

          firstly we should decide if we want to change coding style, I for one don't, apart from my personal preference I can't see any gain and only the disadvantage when doing diffs on prior versions of files.

          • 2. Re: volunteer to reformat the branches...
            Yong Hao Gao Master

            I would have to concur with Andy on this issue.

             

            By the way I years ago used this tool

             

            http://www.triemax.com/products/jalopy/

             

            but I'm not sure how good it is for us (and it seems not open source).

            • 3. Re: volunteer to reformat the branches...
              borges Novice

              Clebert Suconic wrote:

               

              We need a volunteer to reformat the 3 branches to the new coding style, add checkstyle to master and these 2 branches and reconfigure eclipse / idea.

               

               

              Any volunteer?

              I am all for a big reformat, and I could do it, but first we need to agree to what to do, or if to do it at all.

               

              Are we just going to use AS7's code style? (that would certainly shorten the discussion at lot...)

              • 4. Re: volunteer to reformat the branches...
                borges Novice

                Andy Taylor wrote:

                 

                [...] only the disadvantage when doing diffs on prior versions of files.

                FWIW,

                 

                If you configure 'git diff' to always use '--ignore-space-change'. You should not see indentation changes.

                 

                In Eclipse to skip whitespaces in diffs you need to set an option at "General -> Compare / Patch: ignore white space"

                 

                'git gui' can also skip showing whitespace changes through this in your .gitconfig

                [gui]

                      diffopts = --ignore-space-change

                 

                Blame/Annotations:

                 

                'git blame -w' has the same effect.

                 

                At least Eclipse can be configured to always use this option when annotating (blaming on) a file ("Team -> Git: blame annotations").

                • 5. Re: volunteer to reformat the branches...
                  Clebert Suconic Master

                  I'm also used to our current formating, but I think it's a bit out-dated.

                   

                  It would take me some time to get used to it... but that's all... we would have a commit with no other changes as apart to the formatting, so we would be good on history.

                   

                   

                   

                  But I'm easy with that...    if that's causing more issues than benefits lets just leave the formatting as it is... we have other battles to win.

                   

                   

                  If we decide to keep the current formatting we will need to add Checkstyle to the current formatting.