JBossDeveloper

Guys I am trying to follow the post.

You say the Bean has to be proxied; on the call that is Async if I understand correctly.

So, I need move the code that needs to be Asynch to a new bean (or pull some code out to the calling bean) such that the "entry" call into the bean is the one that has @Asynchronous on it.

Ill give that a whirl.

And reading it again; you actually say its the @TransactionAttribute that needs to be proxied (and be the entry method).

DOH!

So the Aynch method can be living inside the bean still; and be called locally to the bean.

Refactored (hopefully as you described):

Controller is called (from a button click but will be a timer eventually)

public void getCustomers() {
        this.logger.info(">>>getCustomers");
        if ((this.future == null) || this.future.isDone()) {
            this.future = this.customerHarvestFromXXXService.run();
            this.postGlobalMessage("request_to_process_accepted", FacesMessage.SEVERITY_INFO);
        } else {
            this.postGlobalMessage("still_processing", FacesMessage.SEVERITY_INFO);
        }
        this.logger.info("<<<getCustomers");
    }

this calls a NEW Injected bean which has a "business" routine (has to be public!)

    /**
     * This method is asynchronous and does not need a TXN as we call other routines that can take time.
     * The called routine, that does the batches, does need a new transaction for each batch.
     * @see https://community.jboss.org/message/782528#782528
     */
    @Asynchronous
    @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED)
    public Future<String> run() {
        String status;
        this.logger.info(">>>Run");
        logger.info("Transaction: "+ ut);
        customerHarvestFromXXXXBatchProcessor.clearErrors();
        try {    
            logger.info("Transaction: "+ ut);
            boolean logEachCustomer = false;
            Collection<SalesPoint> customersFromXXX = new ArrayList<SalesPoint>();

            Connection con = null;
            String url = xxxx:";
            String dbName = "xxx";
            String driver = "oracle.jdbc.OracleDriver";
            String userName = "xxxxREADONLYxxxx";
            String password = "xxxxxx";
            String query = ...
            ... Some gnarly sql
             ... set up a local objects and put in batches
             ... customerHarvestFromXXXXBatchProcessor.processXXXCustomerBatch(customersFromXXXInBatch);
             ...
      return new AsyncResult<String>(status);
    }

this calls a NEW Injected bean which has a "business" routine (has to be public!)

    // Lets start a new (very clean) transaction for handling each customer batch as we need to store the new "real" customer object
    // against the Territory (Don't want to do all the customers in 1 Trans as timeout will kick in)
    // @see https://community.jboss.org/message/782528#782528
    @TransactionAttribute(TransactionAttributeType.REQUIRES_NEW)
    public void processXXXXCustomerBatch(Collection<SalesPoint> customersFromXXXXInBatch) {
        
        logger.info("Transaction: "+ ut);
        
        this.logger.info("Processing Batch...");

        ...
        this.em.persist(customer);
        this.em.flush();
        ...

I believe I have done the refactoring you suggested.

The "entry" routines to each bean are the ones that get annotated as they need to be Proxied.

Hope it does what I am hoping for.

(As I said; a quickstarter for this would be useful as not much of this is documented and full of gotchas)

A nice "feature" of this new setup is that I can call the getErrors method in the "batch" class and can see them come in instead of having to handle the concurrency Exception that I used to get...

       try {
            this.mappingErrorsFromImport = customerHarvestFromXXXBatchProcessor.getErrors(); // TODO Make a copy
        } catch (EJBTransactionRolledbackException eJBTRE) {
            this.postGlobalMessage("still_processing", FacesMessage.SEVERITY_INFO);
            destinationToReturn = "pretty:home";
        }