2 Replies Latest reply on Jan 17, 2013 3:31 AM by thradec

SHRINKWRAP-326 ExplodedImporter should support shrinkwrap filtering

thradec Jan 10, 2013 7:28 AM

Hi all

I tried to implement issue SHRINKWRAP-326 ExplodedImporter should support shrinkwrap filtering [1].

I added two new method into ExplodedImporter with filter parametr, see [2].

Please let me know if these small change in api is acceptable or not.

Cheers Tomas

1. Re: SHRINKWRAP-326 ExplodedImporter should support shrinkwrap filtering

alrubinger Jan 16, 2013 8:32 AM (in response to thradec)

Looks great! Thank you and welcome to ShrinkWrap contribution! This is now upstream:

https://github.com/shrinkwrap/shrinkwrap/commit/73a6cf0596b301446066f9f28b5f9605c93e23be

Sorry about the delay; my workflow is more closely monitoring pull requests on the upstream project than the forums. So in the future feel free to submit a PR via the GitHub UI.

S,
ALR
Actions
2. Re: SHRINKWRAP-326 ExplodedImporter should support shrinkwrap filtering

thradec Jan 17, 2013 3:31 AM (in response to alrubinger)

Thanks for accepting and you're welcome ;-).
T.
Actions