Martin Kouba wrote:

 

Hi Jeff,

 

I don't think you should create AnnotatedType from JMSContext. There is no @JMSPasswordCredential or @JMSSessionMode defined on it... Where are these annotations supposed to be defined at all? And you should not create InjectionTarget either. Instead return an empty set for getInjectionPoints().

@JMSPasswordCredential and @JMSSessionMode are annotations defined in the JMS 2.0[1] that can be used to qualify the injected JMSContext

BTW your producer will not work because CDI doesn't know how to satisfy "ConnectionFactory cf, int ackMode, String userName, String password" parameter injection points.

Yes, that's the thing I don't get: when I create a HornetQJMSContext from an annotated JMSContext, how do I get the associated annotations (@JMSPasswordCredential, etc.)? That's why I wanted to create an injection target for it and get its associated injection points.

Also take a look at Hibernate Validator (Bean Validation RI) integration code (AFAIK this code should be working now):

https://github.com/hibernate/hibernate-validator/blob/master/cdi/src/main/java/org/hibernate/validator/internal/cdi

I'll take a look, thanks,

jeff

[1] https://jms-spec.java.net/2.0/apidocs/index.html

John Ament wrote:

 

I don't believe that HornetQ is JMS 2 compliant yet.  I don't see a class named "HornetQJMSContext" in their github repo.

Yes, HornetQ is not JMS 2 compliant yet (the JMS 2.0 work is done in a jms2 branch at the moment).

After reading carefully the JMS 2.0 spec, it's not HornetQ job to support injection of JMSContext. I'll do this in WildFly messaging subsystem instead.

Hi Martin,

Martin Kouba wrote:

 

BTW your producer will not work because CDI doesn't know how to satisfy "ConnectionFactory cf, int ackMode, String userName, String password" parameter injection points.

 

Also take a look at Hibernate Validator (Bean Validation RI) integration code (AFAIK this code should be working now):

https://github.com/hibernate/hibernate-validator/blob/master/cdi/src/main/java/org/hibernate/validator/internal/cdi

I followed the Hibernate Validator code and I was able to instantiate an injected JMSContext object[1] by providing a simple bean for it[2].

However, the injected resource can be annotated with JMS 2.0 annotations (eg @JMSConnectionFactory[3]). I don't understand how I can fetch the annotations bound to the injected resource to instantiate it properly. Should I declare injection points in the Bean<JMSContext> definition for each JMS 2.0 annotations?

Looking at Weld/CDI doc, it seems I could also use a producer factory with the InjectionPoint but then I don't see how it is related to the creation of the resource in Bean<JMSContext>.create()?

Do you have any example to created such injected resources customized with annotations (that are not @Qualifier)?

thanks

[1] https://github.com/jmesnil/wildfly/blob/e9c82af7841495f9f2406f5444394ca35f46cfba/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/jms/SimplifiedJMSClientTestCase.java#L61

[2] https://github.com/jmesnil/wildfly/blob/e9c82af7841495f9f2406f5444394ca35f46cfba/messaging/src/main/java/org/jboss/as/messaging/deployment/JMSContextBean.java

[3] https://jms-spec.java.net/2.0/apidocs/javax/jms/JMSConnectionFactory.html

I finally figured it out thanks to john and martin's help.

The CDI injection code I added was correct after following the seam 3 example but there was a dependency issue preventing the injection to work.

My issue was pretty specific to WildFly:

- the CDI producer for the injected context was in the messaging subsystem

- when the bean archive was deployed, I added an annotated type for it

- however, Weld was not finding my producer method when it was validating the injection because the messaging module classes were not visible from the deployed archive module loaded.

=> I fixed it by adding a module dependency to it and it works as expected

Thanks for the help (and the awesome documentation),

jeff