4 Replies Latest reply on Sep 5, 2013 9:43 AM by manarh

Page context not restored correctly in seam 2.3.1.Final

brentdouglas Aug 12, 2013 9:05 AM

I have been investigating some issues migrating from seam 2.2 to 2.3. Symptoms were <h:selectOneMenu>'s with <s:convertEntity> tags not working correctly and after a bit of digging I was seeing the converter getting an empty EntityIdentifierStore in validation phase of the post request. A bit more digging and I found this line changed:

https://github.com/seam2/jboss-seam/blob/Seam_2_3/jboss-seam/src/main/java/org/jboss/seam/contexts/PageContext.java#L155

Slipped into this monster commit.

https://github.com/seam2/jboss-seam/commit/d87af0748ce484a0f09018a7b048f43c6839f8f0

After reverting it these tags are working correctly again. Was this change intentional or did it make it into that commit accidentally?

I'm using:

Fedora 19

AS 7.2.0

Seam 2.3.1

Seam UI 2.2.2

Facelets 1.1.15.B1

Richfaces 3.3.4

Mojarra 2.1.18-jbossorg-1 (from as7, not bundled)

1. Re: Page context not restored correctly in seam 2.3.1.Final

manarh Aug 27, 2013 10:46 AM (in response to brentdouglas)

Brent,

Seam 2.3.1.Final works only with Seam UI 2.3.1.Final and with JSF2. You need to remove Facelets 1.1.15.B1 and Richfaces 3.3.x, these are not for JSF2.
Actions
2. Re: Page context not restored correctly in seam 2.3.1.Final

brentdouglas Sep 4, 2013 8:35 PM (in response to manarh)

Hi Marek,

Thanks for the reply. Unfortunately I don't think I can remove richfaces 3.3 yet as to the best of my knowledge richfaces 4 is not a drop in replacement (right?). Other than the above issue most things seem to be working ok. I had one other issue when binding a hibernate collection to a select many component where mojarra calls something like newCollection = oldCollection.getClass().newInstance(); newCollection.putAll(oldCollection); which results in the new collection not having a session but other than that it has been smooth sailing.

I mentioned the above issue as it caused issues for me (though as you say seam 2.3 is not supposed to work with seam-ui 2.2) and looks like that commit was mostly moving stuff around and then, going against the rest of the commit, PageContext changes from viewRoot.getAttributes() to viewRoot.getViewMap() which to my eye looks suspicious.

Brent
Actions
3. Re: Page context not restored correctly in seam 2.3.1.Final

manarh Sep 5, 2013 8:38 AM (in response to brentdouglas)

Brent,
all of this about removing of RF 3.3 doesn't make sense to me. If you would like to use Richfaces 3 and jboss-seam-ui 2.2.x you need to keep using jboss-seam 2.2.x too (the exact same version). Running on AS 7.2 with JSF1.2 is doable, you need to setup only the proper JSF web container module loading like this Re: I am using JSF 1.2 and getting some problem while accessing the application. and exclude default jsf 2 module in jboss-deployment-structure.xml .

It is true that migration of Richfaces 3 to 4 is not drop-in replacement, but that is still doable - look at RichFaces Migration Guide. 3.3.x - 4.x Migration.
Your effort and results obviously depend on your concrete application RF usage.

With regarding the "suspicious commit" - that was needed due JSF 2 changed its ViewRoot API to get View attributes. But as I am now looking at it, it could be wrong. I will try to dive into that and will post here to bring a final statement ;-)
Actions
4. Re: Page context not restored correctly in seam 2.3.1.Final

manarh Sep 5, 2013 9:43 AM (in response to brentdouglas)

I looked at original request of the commit here [#JBSEAM-4868] Long conversation is time out immediately after redirect - JBoss Issue Tracker
and now it seems Mojarra 2.1.19 works again with ViewRoot.getAttributes() while we had refactored usage of conversationId from request and not restore it from PageContext as before. I will try to revert it back to use ViewRoot,getAttributes in frame of [#JBSEAM-5002] Components included with ui:include src="#{pageScopedViewId} broken - JBoss Issue Tracker
Actions

Go to original post