5 Replies Latest reply on Jan 7, 2014 5:59 PM by George Gastaldi

    [forge-dev] The git-tools addon

    Ivan St. Ivanov Novice

      Hi everybody,

       

      A few hours before 2013 is over, I am very happy to announce that the

      git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.

       

      I have transformed the missing functionality and the tests in Forge core

      addon style: different projects for api, addon, impl (containing the UI

      commands) and tests. The tests are passing both in Eclipse and in Maven. I

      have added javadoc to the APIs, README.asciidoc file and some man commands.

       

      I haven't yet issued a pull request for two reasons:

       

      • I am not sure whether you will want git-tools in the core repository or

      you may want it in another one

      • I expect some feedback from your side on my work

       

      You can access the addon code here:

      https://github.com/ivannov/core/tree/FORGE-1128. Once you build it and

      install it in your local maven repository (Java 7 and Maven 3.1 required),

      you may install it by simply running (FORGE_HOME should be set to Forge 2):

       

      forge --install git-tools

       

      You can review the functionality in the README file:

       

      https://github.com/ivannov/core/tree/FORGE-1128/git-tools

       

      As I have promised, I will send my feedback about the development

      experience in Forge 2. I will also give you some feedback on the command

      line shell usage on Windows (and maybe add some JIRAs to Antonio's list).

      And, Lincoln, I haven't forgot this:

      https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230.

       

      At the end, I wish all of you and your families a very happy, healthy and

      successful 2014!

       

      Cheers,

      Ivan

       

        • 1. Re: [forge-dev] The git-tools addon
          George Gastaldi Master

          Hey Ivan!

           

          We'll review your code asap. I think also we might create a "git-tools-forge-addon" repository in forge organization to distribute that. Wdyt?

           

          May you and your family also have a happy new year.

           

          Best Regards,

           

          George

           

          Em 31/12/2013, às 15:33, "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com> escreveu:

           

          Hi everybody,

           

          A few hours before 2013 is over, I am very happy to announce that the git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.

           

          I have transformed the missing functionality and the tests in Forge core addon style: different projects for api, addon, impl (containing the UI commands) and tests. The tests are passing both in Eclipse and in Maven. I have added javadoc to the APIs, README.asciidoc file and some man commands.

           

          I haven't yet issued a pull request for two reasons:

           

          • I am not sure whether you will want git-tools in the core repository or you may want it in another one

          • I expect some feedback from your side on my work

           

          You can access the addon code here: https://github.com/ivannov/core/tree/FORGE-1128. Once you build it and install it in your local maven repository (Java 7 and Maven 3.1 required), you may install it by simply running (FORGE_HOME should be set to Forge 2):

           

          forge --install git-tools

           

          You can review the functionality in the README file:

           

          https://github.com/ivannov/core/tree/FORGE-1128/git-tools

           

          As I have promised, I will send my feedback about the development experience in Forge 2. I will also give you some feedback on the command line shell usage on Windows (and maybe add some JIRAs to Antonio's list). And, Lincoln, I haven't forgot this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230.

           

          At the end, I wish all of you and your families a very happy, healthy and successful 2014!

           

          Cheers,

          Ivan

           

           

          _______________________________________________

          forge-dev mailing list

          forge-dev@lists.jboss.org

          https://lists.jboss.org/mailman/listinfo/forge-dev

           

          • 2. Re: [forge-dev] The git-tools addon
            Ivan St. Ivanov Novice

            Hey George,

             

            Waiting for your feedback!

             

            About the repository: I don't think that git-tools should be part of the

            forge core. However, having a separate repository for each addon is a

            little bit too much for me. Maybe we can stick to the Forge 1 way: have one

            repository for non-core addons and let the people decide where to put their

            own. In that repo or in a repo they decide.

             

            Cheers and Happy new year!

            Ivan

             

             

            On Tue, Dec 31, 2013 at 7:40 PM, George Gastaldi <ggastald@redhat.com>wrote:

             

            Hey Ivan!

             

            We'll review your code asap. I think also we might create a

            "git-tools-forge-addon" repository in forge organization to distribute

            that. Wdyt?

             

            May you and your family also have a happy new year.

             

            Best Regards,

             

            George

             

            Em 31/12/2013, às 15:33, "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com>

            escreveu:

             

            Hi everybody,

             

            A few hours before 2013 is over, I am very happy to announce that the

            git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.

             

            I have transformed the missing functionality and the tests in Forge core

            addon style: different projects for api, addon, impl (containing the UI

            commands) and tests. The tests are passing both in Eclipse and in Maven. I

            have added javadoc to the APIs, README.asciidoc file and some man commands.

             

            I haven't yet issued a pull request for two reasons:

             

            • I am not sure whether you will want git-tools in the core repository or

            you may want it in another one

            • I expect some feedback from your side on my work

             

            You can access the addon code here:

            https://github.com/ivannov/core/tree/FORGE-1128. Once you build it and

            install it in your local maven repository (Java 7 and Maven 3.1 required),

            you may install it by simply running (FORGE_HOME should be set to Forge 2):

             

            forge --install git-tools

             

            You can review the functionality in the README file:

             

            https://github.com/ivannov/core/tree/FORGE-1128/git-tools

             

            As I have promised, I will send my feedback about the development

            experience in Forge 2. I will also give you some feedback on the command

            line shell usage on Windows (and maybe add some JIRAs to Antonio's list).

            And, Lincoln, I haven't forgot this:

            https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230.

             

            At the end, I wish all of you and your families a very happy, healthy and

            successful 2014!

             

            Cheers,

            Ivan

             

            >

            _______________________________________________

            forge-dev mailing list

            forge-dev@lists.jboss.org

            https://lists.jboss.org/mailman/listinfo/forge-dev

             

            >

            _______________________________________________

            forge-dev mailing list

            forge-dev@lists.jboss.org

            https://lists.jboss.org/mailman/listinfo/forge-dev

             

             

            • 3. Re: [forge-dev] The git-tools addon
              George Gastaldi Master

              I created the repository https://github.com/forge/addon-git and gave you the necessary permissions to push. Could you move it to this repository?

              Thanks!

               

              -


              Original Message -


              From: "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com>

              To: "forge-dev List" <forge-dev@lists.jboss.org>

              Sent: Wednesday, January 1, 2014 9:28:27 AM

              Subject: Re: The git-tools addon

               

              Hey George,

               

              Waiting for your feedback!

               

              About the repository: I don't think that git-tools should be part of the forge core. However, having a separate repository for each addon is a little bit too much for me. Maybe we can stick to the Forge 1 way: have one repository for non-core addons and let the people decide where to put their own. In that repo or in a repo they decide.

               

              Cheers and Happy new year!

              Ivan

               

               

              On Tue, Dec 31, 2013 at 7:40 PM, George Gastaldi < ggastald@redhat.com > wrote:

               

               

               

              Hey Ivan!

               

              We'll review your code asap. I think also we might create a "git-tools-forge-addon" repository in forge organization to distribute that. Wdyt?

               

              May you and your family also have a happy new year.

               

              Best Regards,

               

              George

               

              Em 31/12/2013, às 15:33, "Ivan St. Ivanov" < ivan.st.ivanov@gmail.com > escreveu:

               

               

               

               

              Hi everybody,

               

              A few hours before 2013 is over, I am very happy to announce that the git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.

               

              I have transformed the missing functionality and the tests in Forge core addon style: different projects for api, addon, impl (containing the UI commands) and tests. The tests are passing both in Eclipse and in Maven. I have added javadoc to the APIs, README.asciidoc file and some man commands.

               

              I haven't yet issued a pull request for two reasons:

               

              • I am not sure whether you will want git-tools in the core repository or you may want it in another one

              • I expect some feedback from your side on my work

               

              You can access the addon code here: https://github.com/ivannov/core/tree/FORGE-1128 . Once you build it and install it in your local maven repository (Java 7 and Maven 3.1 required), you may install it by simply running (FORGE_HOME should be set to Forge 2):

               

              forge --install git-tools

               

              You can review the functionality in the README file:

               

              https://github.com/ivannov/core/tree/FORGE-1128/git-tools

               

              As I have promised, I will send my feedback about the development experience in Forge 2. I will also give you some feedback on the command line shell usage on Windows (and maybe add some JIRAs to Antonio's list). And, Lincoln, I haven't forgot this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230 .

               

              At the end, I wish all of you and your families a very happy, healthy and successful 2014!

               

              Cheers,

              Ivan

               

               

               

               

               

              _______________________________________________

              forge-dev mailing list

              forge-dev@lists.jboss.org

              https://lists.jboss.org/mailman/listinfo/forge-dev

               

              _______________________________________________

              forge-dev mailing list

              forge-dev@lists.jboss.org

              https://lists.jboss.org/mailman/listinfo/forge-dev

               

               

              _______________________________________________

              forge-dev mailing list

              forge-dev@lists.jboss.org

              https://lists.jboss.org/mailman/listinfo/forge-dev

               

              _______________________________________________

              forge-dev mailing list

              forge-dev@lists.jboss.org

              https://lists.jboss.org/mailman/listinfo/forge-dev

               

               

              • 4. Re: [forge-dev] The git-tools addon
                Ivan St. Ivanov Novice

                Hey George,

                 

                Thanks for that! I pushed my addon to the FORGE-1128 branch there:

                https://github.com/forge/addon-git/tree/FORGE-1128

                 

                I didn't know where did you want it: master, 2.0... So I used the feature

                branch.

                 

                Cheers,

                Ivan

                 

                 

                On Tue, Jan 7, 2014 at 7:47 PM, George Gastaldi <ggastald@redhat.com> wrote:

                 

                I created the repository https://github.com/forge/addon-git and gave you

                the necessary permissions to push. Could you move it to this repository?

                Thanks!

                 

                ----- Original Message -----

                From: "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com>

                To: "forge-dev List" <forge-dev@lists.jboss.org>

                Sent: Wednesday, January 1, 2014 9:28:27 AM

                Subject: Re: The git-tools addon

                 

                Hey George,

                 

                Waiting for your feedback!

                 

                About the repository: I don't think that git-tools should be part of the

                forge core. However, having a separate repository for each addon is a

                little bit too much for me. Maybe we can stick to the Forge 1 way: have one

                repository for non-core addons and let the people decide where to put their

                own. In that repo or in a repo they decide.

                 

                Cheers and Happy new year!

                Ivan

                 

                >

                On Tue, Dec 31, 2013 at 7:40 PM, George Gastaldi < ggastald@redhat.com >

                wrote:

                 

                >

                 

                Hey Ivan!

                 

                We'll review your code asap. I think also we might create a

                "git-tools-forge-addon" repository in forge organization to distribute

                that. Wdyt?

                 

                May you and your family also have a happy new year.

                 

                Best Regards,

                 

                George

                 

                Em 31/12/2013, às 15:33, "Ivan St. Ivanov" < ivan.st.ivanov@gmail.com >

                escreveu:

                 

                >

                >

                Hi everybody,

                 

                A few hours before 2013 is over, I am very happy to announce that the

                git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.

                 

                I have transformed the missing functionality and the tests in Forge core

                addon style: different projects for api, addon, impl (containing the UI

                commands) and tests. The tests are passing both in Eclipse and in Maven. I

                have added javadoc to the APIs, README.asciidoc file and some man commands.

                 

                I haven't yet issued a pull request for two reasons:

                 

                • I am not sure whether you will want git-tools in the core repository or

                you may want it in another one

                • I expect some feedback from your side on my work

                 

                You can access the addon code here:

                https://github.com/ivannov/core/tree/FORGE-1128 . Once you build it and

                install it in your local maven repository (Java 7 and Maven 3.1 required),

                you may install it by simply running (FORGE_HOME should be set to Forge 2):

                 

                forge --install git-tools

                 

                You can review the functionality in the README file:

                 

                https://github.com/ivannov/core/tree/FORGE-1128/git-tools

                 

                As I have promised, I will send my feedback about the development

                experience in Forge 2. I will also give you some feedback on the command

                line shell usage on Windows (and maybe add some JIRAs to Antonio's list).

                And, Lincoln, I haven't forgot this:

                https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230 .

                 

                At the end, I wish all of you and your families a very happy, healthy and

                successful 2014!

                 

                Cheers,

                Ivan

                 

                >

                >

                 

                _______________________________________________

                forge-dev mailing list

                forge-dev@lists.jboss.org

                https://lists.jboss.org/mailman/listinfo/forge-dev

                 

                _______________________________________________

                forge-dev mailing list

                forge-dev@lists.jboss.org

                https://lists.jboss.org/mailman/listinfo/forge-dev

                 

                >

                _______________________________________________

                forge-dev mailing list

                forge-dev@lists.jboss.org

                https://lists.jboss.org/mailman/listinfo/forge-dev

                 

                _______________________________________________

                forge-dev mailing list

                forge-dev@lists.jboss.org

                https://lists.jboss.org/mailman/listinfo/forge-dev

                 

                 

                • 5. Re: [forge-dev] The git-tools addon
                  George Gastaldi Master

                  Master would be fine, thanks! I'll try it out.

                   

                  Em 07/01/2014, às 20:20, "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com> escreveu:

                   

                  Hey George,

                   

                  Thanks for that! I pushed my addon to the FORGE-1128 branch there: https://github.com/forge/addon-git/tree/FORGE-1128

                   

                  I didn't know where did you want it: master, 2.0... So I used the feature branch.

                   

                  Cheers,

                  Ivan

                   

                   

                  >> On Tue, Jan 7, 2014 at 7:47 PM, George Gastaldi <ggastald@redhat.com> wrote:

                  >> I created the repository https://github.com/forge/addon-git and gave you the necessary permissions to push. Could you move it to this repository?

                  >> Thanks!

                  >>

                  >> -


                  Original Message -


                  >> From: "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com>

                  >> To: "forge-dev List" <forge-dev@lists.jboss.org>

                  >> Sent: Wednesday, January 1, 2014 9:28:27 AM

                  >> Subject: Re: The git-tools addon

                  >>

                  >> Hey George,

                  >>

                  >> Waiting for your feedback!

                  >>

                  >> About the repository: I don't think that git-tools should be part of the forge core. However, having a separate repository for each addon is a little bit too much for me. Maybe we can stick to the Forge 1 way: have one repository for non-core addons and let the people decide where to put their own. In that repo or in a repo they decide.

                  >>

                  >> Cheers and Happy new year!

                  >> Ivan

                  >>

                  >>

                  >> On Tue, Dec 31, 2013 at 7:40 PM, George Gastaldi < ggastald@redhat.com > wrote:

                  >>

                  >>

                  >>

                  >> Hey Ivan!

                  >>

                  >> We'll review your code asap. I think also we might create a "git-tools-forge-addon" repository in forge organization to distribute that. Wdyt?

                  >>

                  >> May you and your family also have a happy new year.

                  >>

                  >> Best Regards,

                  >>

                  >> George

                  >>

                  >> Em 31/12/2013, às 15:33, "Ivan St. Ivanov" < ivan.st.ivanov@gmail.com > escreveu:

                  >>

                  >>

                  >>

                  >>

                  >> Hi everybody,

                  >>

                  >> A few hours before 2013 is over, I am very happy to announce that the git-tools plugin from Forge 1 is finally migrated to a Forge 2 addon.

                  >>

                  >> I have transformed the missing functionality and the tests in Forge core addon style: different projects for api, addon, impl (containing the UI commands) and tests. The tests are passing both in Eclipse and in Maven. I have added javadoc to the APIs, README.asciidoc file and some man commands.

                  >>

                  >> I haven't yet issued a pull request for two reasons:

                  >>

                  >> * I am not sure whether you will want git-tools in the core repository or you may want it in another one

                  >> * I expect some feedback from your side on my work

                  >>

                  >> You can access the addon code here: https://github.com/ivannov/core/tree/FORGE-1128 . Once you build it and install it in your local maven repository (Java 7 and Maven 3.1 required), you may install it by simply running (FORGE_HOME should be set to Forge 2):

                  >>

                  >> forge --install git-tools

                  >>

                  >> You can review the functionality in the README file:

                  >>

                  >> https://github.com/ivannov/core/tree/FORGE-1128/git-tools

                  >>

                  >> As I have promised, I will send my feedback about the development experience in Forge 2. I will also give you some feedback on the command line shell usage on Windows (and maybe add some JIRAs to Antonio's list). And, Lincoln, I haven't forgot this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=368230 .

                  >>

                  >> At the end, I wish all of you and your families a very happy, healthy and successful 2014!

                  >>

                  >> Cheers,

                  >> Ivan

                  >>

                  >>

                  >>

                  >>

                  >>

                  >> _______________________________________________

                  >> forge-dev mailing list

                  >> forge-dev@lists.jboss.org

                  >> https://lists.jboss.org/mailman/listinfo/forge-dev

                  >>

                  >> _______________________________________________

                  >> forge-dev mailing list

                  >> forge-dev@lists.jboss.org

                  >> https://lists.jboss.org/mailman/listinfo/forge-dev

                  >>

                  >>

                  >> _______________________________________________

                  >> forge-dev mailing list

                  >> forge-dev@lists.jboss.org

                  >> https://lists.jboss.org/mailman/listinfo/forge-dev

                  >>

                  >> _______________________________________________

                  >> forge-dev mailing list

                  >> forge-dev@lists.jboss.org

                  >> https://lists.jboss.org/mailman/listinfo/forge-dev

                   

                  _______________________________________________

                  forge-dev mailing list

                  forge-dev@lists.jboss.org

                  https://lists.jboss.org/mailman/listinfo/forge-dev