1 Reply Latest reply on Apr 6, 2014 2:52 PM by Ivan St. Ivanov

    Re: [forge-dev] Where to create the set compiler version UI command?

    Lincoln Baxter III Master

      I agree with George. I think that parser-java is probably the right place

      for this. The command should be active if there is a current project, and

      JavaCompilerFacet is enabled in that project. The command is build-system

      agnostic, so it shouldn't go in maven. I think parser-java is the only

      place for it.

       

       

      On Sun, Apr 6, 2014 at 1:24 PM, George Gastaldi <ggastald@redhat.com> wrote:

       

      Why not adding to parser-java? That seems the best place to be, since

      JavaCompilerFacet is in there

       

      Em 06/04/2014, às 14:14, "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com>

      escreveu:

       

      Hi guys!

       

      I was wondering where to put the compiler version UI command. it has

      dependency to parser-java (because of the Facet), so it can't go to the

      projects addon. Otherwise it would introduce a circular dependency. I am

      not really happy about adding the command to the parser-java addon either.

       

      I looked at all the addons that have dependency to parser-java, but

      couldn't find any suitable (dev-tools, addons, scaffold, javaee,

      database-tools).

       

      What would you recommend here?

       

      Thanks,

      Ivan

       

       

       

      --

      Lincoln Baxter, III

      http://ocpsoft.org

      "Simpler is better."

       

        • 1. Re: [forge-dev] Where to create the set compiler version UI command?
          Ivan St. Ivanov Novice

          Thanks for the quick answer, folks!

          On Apr 6, 2014 8:26 PM, "Lincoln Baxter, III" <lincolnbaxter@gmail.com>

          wrote:

           

          I agree with George. I think that parser-java is probably the right place

          for this. The command should be active if there is a current project, and

          JavaCompilerFacet is enabled in that project. The command is build-system

          agnostic, so it shouldn't go in maven. I think parser-java is the only

          place for it.

           

          >

          On Sun, Apr 6, 2014 at 1:24 PM, George Gastaldi <ggastald@redhat.com>wrote:

           

          >> Why not adding to parser-java? That seems the best place to be, since

          >> JavaCompilerFacet is in there

          >>

          >> > Em 06/04/2014, às 14:14, "Ivan St. Ivanov" <ivan.st.ivanov@gmail.com>

          >> escreveu:

          >> >

          >> > Hi guys!

          >> >

          >> > I was wondering where to put the compiler version UI command. it has

          >> dependency to parser-java (because of the Facet), so it can't go to the

          >> projects addon. Otherwise it would introduce a circular dependency. I am

          >> not really happy about adding the command to the parser-java addon either.

          >> >

          >> > I looked at all the addons that have dependency to parser-java, but

          >> couldn't find any suitable (dev-tools, addons, scaffold, javaee,

          >> database-tools).

          >> >

          >> > What would you recommend here?

          >> >

          >> > Thanks,

          >> > Ivan

          >>

          >

          >

          --

          Lincoln Baxter, III

          http://ocpsoft.org

          "Simpler is better."