So i talked to the hibernate crew, and they advised me NOT to set the factory_class. I instead set the lookup_class. The lookup classes extend from a JNDI class, so i exposed the proper values from the source of the class i decided to use. I might in the future use a custom class in case the values for the supplied class ever change.
So remove the lookup_class from the jpa-persistence.xml jpaProperties, and add this instead to the jpaProperties,
hibernate.transaction.manager_lookup_class => org.hibernate.transaction.JBossTransactionManagerLookup
and in the jndi.xml, i added these to accommodate the JBossTransactionManagerLookup,
Then it works... kind-of. Transactions still dont roll back, but i dont get any warnings and things seemingly are configured correctly. Im wading thru spring/hibernate/fusesource(geronimo TX Mgr)/ and i will hope to update sometime in the future
I still have a problem, but it does not pertain to this question, which i solved. I will post with the new question in a new thread