Hello rich faced devs!
in action. I really like how they remove a much of the DOM setup of the
integration tests. A powerful abstraction indeed.
However I'm a little concerned over some of the generic names we have in
the above PR. It has methods (among others) with the following names:
RichFacesTabPanel#getRootOfContainerElement() to return the content
element of the TabPanel component
RichFacesTabPanel#getSwitcherControllerElements() to get the headers
of the parent Tab
Both of these names are quite generic since they are inherited from a
parent class that shared amongst all switchable components. However,
for both these methods the super method is abstract, so there is no
shared implementation. Can someone with more knowledge of the page
fragments implementation explain the benefit of the method inheritance
here? IMO the abstraction leaves us with an unclear API which won't
If we can come to an agreement of how we can improve this, we can scan
the remaining page fragments for methods that can benefit from a similar
Also, while on the subject of page fragments, I noticed the javadoc for
page fragments is not included in our generated javadoc. This also will
the javadoc for page fragments. Please comment there if you feel they
shouldn't be included.
att1.html.zip 1.3 K