6 Replies Latest reply on Sep 20, 2016 1:58 AM by jaikiran

file.encoding for sql-load-script-source

kireevdavid80 Jul 2, 2016 3:01 PM

Hi!

I'm trying to use the sql-load-script-source property in persistence.xml but there is something wrong with file encoding.

property - <property name="javax.persistence.sql-load-script-source" value="META-INF/load.sql"/>

load.sql file's encoding is UTF-8 (it contains cyrillic and french characters)

file.encoding system property was by default windows-1252 and that way (broken) it was written to DB (MySQL with table collation = utf8_general_ci)

setting file.encoding to UTF-8 didn't help - file still was read with windows-1252 encoding

I'm using WildFly 10.0.0.Final which uses by default Hibernate 5.0.7.

I used debugger and dug into org.hibernate.jpa.internal.schemagen.ScriptSourceInputFromUrl.toReader which returned a reader (InputStreamReader) for load.sql with encoding got from Charset.defaultCharset() which in turn should have got it from file.encoding

What am I missing? Is there any javax.persistence.* property to specify encoding of script files?

1. Re: file.encoding for sql-load-script-source

babazs Jul 25, 2016 1:28 PM (in response to kireevdavid80)

Hi!

I used the -Dfile.encoding=UTF-8 jvm option, so wildfly pick it up when it starts. It worked for me.

<configuration>
<jboss-home>c:\web\wildfly-10.0.0.Final\</jboss-home>
<javaOpts>
<javaOpt>-Dfile.encoding=UTF-8</javaOpt>
</javaOpts>
.... !
Actions
2. Re: file.encoding for sql-load-script-source

jaikiran Jul 29, 2016 9:35 AM (in response to kireevdavid80)

David Kireev wrote:

What am I missing? Is there any javax.persistence.* property to specify encoding of script files?

Keep a watch on this enhancement request https://hibernate.atlassian.net/browse/HHH-10972
Actions
3. Re: file.encoding for sql-load-script-source

kireevdavid80 Aug 31, 2016 8:48 PM (in response to jaikiran)

Thanks a lot, jaikiran pai! Sorry, it took me too long to see your post.
But I'm still not happy about their decision to use the default JVM encoding instead of the file.encoding property's value when the Hibernate-specific configuration property isn't set
Did you do any further work on your pull request?
Actions
4. Re: file.encoding for sql-load-script-source

jaikiran Sep 1, 2016 1:05 AM (in response to kireevdavid80)

David Kireev wrote:
Did you do any further work on your pull request?
I actually forgot about that in other things. I'll get to it this week.
Actions
5. Re: file.encoding for sql-load-script-source

kireevdavid80 Sep 1, 2016 5:11 AM (in response to jaikiran)

I'll be really grateful!
Actions
6. Re: file.encoding for sql-load-script-source

jaikiran Sep 20, 2016 1:58 AM (in response to kireevdavid80)

The Hibernate team themselves have fixed this issue last week [HHH-10972] Use UTF-8 charset for reading files for initializing the database (javax.persistence.sql-load-script-source …

Here's the change https://github.com/hibernate/hibernate-orm/pull/1551
Actions

Go to original post