Refactoring StringBuffer to StringBuilder

ochaloup May 17, 2017 11:17 AM

Hi,

I just hit this article

https://vanilla-java.github.io/2017/04/13/String-Buffer-and-how-hard-it-is-to-get-rid-of-legacy-code.html

I interested if you give +1 on changing StringBuffer for StringBuilder at places where it's used in Narayana code. I expect it's an optional task but for case of no objections, I would create a jira to track the idea.

What do you think?

Thanks

Ondra

1. Re: Refactoring StringBuffer to StringBuilder

tomjenkinson May 17, 2017 10:34 AM (in response to ochaloup)

I am sceptical as to whether it would have any material effect on Narayana performance or runtime profile. I don't expect that as a normal 2PC we would actually use StringBuffer at all? Do you see any examples of that?
1 of 1 people found this helpful
Actions
2. Re: Refactoring StringBuffer to StringBuilder

mmusgrov May 17, 2017 10:38 AM (in response to ochaloup)

We have Performance Gates for accepting performance fixes in Narayana for accepting performance related fixes. If you raise a PR and check the PERF profile you can quantify the effect of your enhancements.
Actions
3. Re: Refactoring StringBuffer to StringBuilder

ochaloup May 17, 2017 11:16 AM (in response to ochaloup)

tomjenkinson I see, agree. I think performance probably would not get much better. I feel it more like refactoring task where the aim is to have a better code.
mmusgrov that's the good point, I think going that way is the ideal.
Actions

Go to original post