5 Replies Latest reply on Nov 8, 2017 10:14 AM by clagio

cache.clear inside a batch

clagio Nov 6, 2017 5:09 AM

Hello,

It's possible to use a cache.clear inside a batch transaction?

I have a code like this:

app.cache.startBatch();
app.cache.clear();
app.cache.put("k1","value1");
app.cache.endBatch(true);

Which gives the following error:

ERROR: ISPN000136: Error executing command SizeCommand, writing keys []

java.lang.IllegalStateException: Transaction EmbeddedTransaction{xid=Xid{formatId=1, globalTransactionId=85C51E23E9A44DF629C6535A1060461F0000000000000003,branchQualifier=85C51E23E9A44DF629C6535A1060461F0000000000000003}, status=COMMITTED} is not in a valid state to be invoking cache operations on.

at org.infinispan.interceptors.impl.TxInterceptor.enlist(TxInterceptor.java:486)

If I move the cache.clear outside the batch, I don't have errors... Checking the code behind cache.clear in the Cache.java I see the following comment:

/**

* Removes all mappings from the cache.

* <p/>

  * <b>Note:</b> This should never be invoked in production unless you can guarantee no other invocations are ran

* concurrently.

* <p/>

* If the cache is transactional, it will not interact with the transaction.

Could be that there is a conflict between the startbatch transaction and the transaction (?) started by the cache.clear?

Thanks

1. Re: cache.clear inside a batch

pruivo Nov 6, 2017 6:56 AM (in response to clagio)
Hi clagio,

There is bug with clear() and batching together. I opened a JIRA for the issue: [ISPN-8494] Clear is leaking transaction with Batching - JBoss Issue Tracker .

It should be fixed in the next release. For now, I advice you to move the clear outside the batching or, if you need it inside the batching, execute in another thread like:

CompletableFuture.runAsync(cache::clear).get();

Thanks for your help.

Cheers,
Pedro
Actions
2. Re: cache.clear inside a batch

clagio Nov 6, 2017 7:16 AM (in response to pruivo)

Thanks for the suggestion and the link to the bug!
Actions
3. Re: cache.clear inside a batch

clagio Nov 7, 2017 7:08 AM (in response to pruivo)

Hello Pedro,
What happen to the startBatch transaction in case the cache.clear executed by CompletableFuture fails?
Or what if some other actions executed in the startBatch are failing? The cache.clear will be committed anyway?

Thanks
Actions
4. Re: cache.clear inside a batch

pruivo Nov 8, 2017 9:02 AM (in response to clagio)

Hi clagio,

The clear() is isolated from the batch. So, if it fails, it doesn't fails the batch. If another operation in batch fails, the clear() is still committed.
Note that the clear() is committed when it executes and not when the batch ends!

Cheers,
Pedro
Actions
5. Re: cache.clear inside a batch

clagio Nov 8, 2017 10:14 AM (in response to pruivo)

Hi Pedro,

I imagined, thanks for the confirmation, but at this point is not very different from having the cache.clear outside the batch..
Thanks for your help anyway!
Actions

Go to original post