5 Replies Latest reply on Dec 7, 2018 4:51 AM by peter.lang

Wildfly 14 doesn't always call AsyncListener.onComplete()

peter.lang Nov 29, 2018 4:39 AM

In WildFly 14 (undertow Version 2.0.13.Final) I observed a behavior change in asynchronous servlet processing.

Since undertow 2.0.12.Final the `AsyncListener#onComplete()` method is no longer called in my sample.

As my app tries to release allocated resources in the `onComplete()` callback as suggested by the servlet specification,

I rely on this callback for resource cleanup.

@Override
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {
  req.startAsync(); 
  throw new NullPointerException();
}

GitHub - dynatrace-peterlang/undertow-async-snippet: A sample project used for a bugreport to undertow. AsyncErrorServlet

Could you please check, if this is a bug in undertwo 2.0.12.Final / WildFly14? Could this be a duplicate to [UNDERTOW-556] Exception after startAsync results in error page with HTTP status code 200 - JBoss Issue Tracker ?

Thank you very much for you help,

Peter

1. Re: Wildfly 14 doesn't always call AsyncListener.onComplete()

jstourac Dec 3, 2018 1:34 PM (in response to peter.lang)

Hi Peter, thanks for reporting this here. It looks like a regression in Undertow.

swd847 could you please look at it? Looking briefly to the changes between 2.0.11.Final and 2.0.12.Final [1], there are two commits that might be related to this change of behavior:

UNDERTOW-1381 Don't actually complete() the async context until the t… · undertow-io/undertow@7f60713 · GitHub
UNDERTOW-1382 HttpServerExchange cannot have both async IO resumed an… · undertow-io/undertow@4d808be · GitHub

If this is really a bug, then this is quite a serious regression, right?

[1] Comparing 2.0.11.Final...2.0.12.Final · undertow-io/undertow · GitHub
Actions
2. Re: Wildfly 14 doesn't always call AsyncListener.onComplete()

mchoma Dec 6, 2018 8:13 AM (in response to peter.lang)

I have created [UNDERTOW-1455] Asynchronous servlet, onComplete() is not called when error occures - JBoss Issue Tracker for this issue.

peter.lang please could you try workaround from UNDERTOW-1455.
Actions
3. Re: Wildfly 14 doesn't always call AsyncListener.onComplete()

peter.lang Dec 6, 2018 10:38 AM (in response to mchoma)

Hi Martin,
I updated my sample on github and created a branch 'undertow-1455-workaround'.
What are your expectations, if I call AsyncContext.complete() in the onError() callback should I receive the onComplete() callback as well?
In my modified sample the ErrorHandlingAsyncListener.onError() calls AsyncContext.complete() as suggested, but the listener for onComplete() gets not called by container.
Thanks for your help,
Peter
Actions
4. Re: Wildfly 14 doesn't always call AsyncListener.onComplete()

mchoma Dec 7, 2018 4:32 AM (in response to peter.lang)

You are right, only workaround I see now is to "Move cleanup onComplete() code to onError() method"
Actions
5. Re: Wildfly 14 doesn't always call AsyncListener.onComplete()

peter.lang Dec 7, 2018 4:51 AM (in response to mchoma)

Thanks for the feedback. Sure I could call cleanup code in onError() as workaround in the meantime, until UNDERTOW-1455 gets fixed.
Actions

Go to original post