-
1. Re: Rename lra-filters to narayana-lra
mmusgrov Aug 20, 2019 6:02 AM (in response to mstefank)Sounds reasonable. Can you raise a PR please?
-
2. Re: Rename lra-filters to narayana-lra
tomjenkinson Aug 20, 2019 6:33 AM (in response to mmusgrov)I think we need a JBTM too to track the work.
I like the change, it should certainly make it clearer. I am wondering though, what about:
> <groupId>org.jboss.narayana.rts.lra</groupId>
From looking at the code I note this would need to be changed across the LRA implementation but it does seem reasonable to nest lra under it's own group.
-
3. Re: Rename lra-filters to narayana-lra
mstefank Aug 20, 2019 6:38 AM (in response to mstefank)I will raise JBTM for lra-filters -> narayana-lra rename. @Tom, what would you suggest as a group id? I will do that in separate JBTM.
-
4. Re: Rename lra-filters to narayana-lra
tomjenkinson Aug 20, 2019 7:21 AM (in response to mstefank)Thanks! My preference would be for org.jboss.narayana.rts.lra to match our standard pattern, but let's see what mmusgrov suggests too?
-
5. Re: Rename lra-filters to narayana-lra
mmusgrov Aug 21, 2019 6:47 AM (in response to tomjenkinson)The group id for all rest based transactions services has, up until now, been org.jboss.narayana.rts
But if there is a preference for org.jboss.narayana.rts.lra then that's fine too.
-
6. Re: Rename lra-filters to narayana-lra
tomjenkinson Aug 21, 2019 6:49 AM (in response to mmusgrov)I think adding .lra helps to partition the work in the maven repo so I would prefer it myself.
-
7. Re: Rename lra-filters to narayana-lra
tomjenkinson Sep 30, 2019 10:00 AM (in response to tomjenkinson)For reference, we did this work under [JBTM-3177] Rename lra-filters to narayana-lra - JBoss Issue Tracker