Ok, I am thinking it is best to use multiple WAR files. I have some common code to all WARs (but is not an EJB), should I deploy the common code in a SAR file so that all WARs can access it on the classpath. That way, I don't have to deploy copies of the same common code in the /lib of each WAR?
If so, I don't really have a service in the SAR, so do I need a jboss-service.xml in the SAR? Final question, should the multiple WAR files be deployed within the SAR or on their own? Is there an advantage/disadvantage to either way?
You can deploy regular Java archives (JARs) as well, you don't need to create SAR archive just for your classes.
There's a single classloader per top level package deployment so whether you deploy multiple packages or single package with many nested subpackages determines your redeployment granularity. Redeploy always replaces an entire classloader (and obviously all components within its scope, including subpackages).