2 Replies Latest reply on Mar 27, 2007 5:05 AM by Shaun Whyte

    Generate Token in SSOUtil

    Shaun Whyte Newbie

      I've been looking in to the source code of JBoss SSO to try to get my head around how it works.

      I've noticed that in the SSOUtil.java class, there is a public method called generateToken(AuthResponse). Within this, there is a call to the sso manager instance to generate a token as a string passing in various attribute values of the AuthResponse object. However, the third and final parameter passed is a boolean which is hard coded as being true. i.e. we have:

      token = sso.generateAuthResponse(response.getAssertingParty(),response.getUser().getUserName(),true);
      

      This third parameter is used as the 'success' flag, however since this is always passed in as true from the SSOUtil, the method always produces a token string that indicates a valid login.

      This generateToken(AuthResponse) method is called by the SSOFederationServer (as part of its doPost):
      AuthResponse authResponse = SSOUtil.getAuthResponse(token);
      String myToken = SSOUtil.generateToken(authResponse);
      

      So from what I am reading, the authResponse object created in the first line here, includes whether the authentication was successful or not (determined by making a call to JBossSingleSignOn.parseAuthResponse(String token) - this call checks that the secret in the token is valid using the TrustServer).

      However, this status flag in the AuthResponse object (isAuthenticated) is not used within the call to SingleSignOn.generateAuthResponse(...) (which is called from within the SSOUtil.generateToken(..) method), instead it's hard coded to true as stated above.

      The effect of this is that if I have two domains in a federation, I was able to capture the token from the first domain, put this in a form, alter the username and even the secret within the token, and then POST it to the federate server in the second domain, and it doesn't throw any errors or send me to the login page, but instead allows me straight through to the resource.

      I've been trying this out with the bundled out-of-the-box SSO test application, and I am indeed able to create a token from a previously generated request, alter the secret or user, and when I then post this to the federate URL on the other domain, it lets me in.

      Would you be able to clarify if my understanding is incorrect here, or if there's a minor bug slipped through?

      Also, one other question, I've noticed that the "secrets" are stored in a collection on the trust server (user->secret mapping), however, I cannot find any way of removing any mappings from this collection, I can only see the "generateSecret" and "validateSecret" actions. Should these mappings be removed when the user logs out? Otherwise, would it not be possible that even after a user has logged out, if someone had intercepted the token, they could log in with the same user->secret in the token?

      Hope this makes sense, its difficult to explain without actually being able to 'point' to lines of code :-).

      Thanks in advance,
      Shaun.

        • 1. Re: Generate Token in SSOUtil
          Sohil Shah Master

          Shaun-

          This looks like a possible bug in integration between the SSOEngine/Federation Server/ and Trust Server.

          The Trust Server is going to go through a major overhaul in version 2.0 with support for WS-Trust spec etc.


          I will dig deeper into this bug and include a fix in the 1.0 GA release.

          Unfortunately, I am really swamped with other priorities in the next couple of weeks, so it will be a couple of weeks before I can take a look at this issue.

          I will keep you posted

          Thanks

          • 2. Re: Generate Token in SSOUtil
            Shaun Whyte Newbie

            Hi Sohil

            Thanks for the swift response. I'll hang on until you've had a look in to it further.

            Many thanks,
            Shaun.