Tim do you want me to add R/W jmx attributes for fullsize, pagesize and downcachesize? Or, since they will be eventually self-tuned, you only want them to be ReadOnly?
Please let me know because the former will require a few changes in DestinationServiceSupport and ChannelMapper.
Yes, please add them as R/W MBean attributes, defaulting to the current values.
Also, the total messages in a channel should be messageref.size +
But some reliable msgs could be duplicated in both messageref and pm. So I need to filter out those duplicated ones plus those received from uncommitted tx. Am I right?
totalMessages in channel = messagerefs.size + deliveries.size() + refsInStorage
no need to call the pm
refsInStorage already contains those in the downCache
no need to worry about tx
Right. I ignored refsInStorage when looking at your changes :)
For subscriptions, do we have MBean to manage them so that I can add the three new parameters? Or we don't have one yet?
For subscriptions, I guess the values should be specified as MBean attributes on the corresponding topic to which the subscriptions subscribe.
So the 3 attributes exist on both the Topic and the Queue Mbeans.
Changes to those attributes will only take effect after restarting the destinations.