4 Replies Latest reply on Mar 29, 2007 1:16 AM by Scott Stark

    org.jboss.test.jbossmq.test cleanup in jboss5

    Scott Stark Master

      I want to go through the org.jboss.test.jbossmq.test package and drop all of the mq specific tests. I'm wondering if its worth keeping the jms agnostic tests as most of them seem to have been duplicated in the org.jboss.test.jbossmessaging.test package though. Maybe the better thing it just to merge any missing coverage.

        • 1. Re: org.jboss.test.jbossmq.test cleanup in jboss5
          Clebert Suconic Master

          I will talk to Richard Achmatowicz about this tomorrow...

          He has done the initial messaging tests... I will talk to him, and I guess the best thing to do would be what you said.

          Last time I talked to him, he was waiting on the 1.2.0.GA release to drop those tests, as some of them would be invalid as we were missing some required features that we have fixed now.

          • 2. Re: org.jboss.test.jbossmq.test cleanup in jboss5
            Richard Achmatowicz Novice

            The org.jboss.test.jbossmessaging.test tests consist of all the JMS tests from org.jboss.test.jbossmq.test which (i) did not have any obvious dependencies on JBossMQ and (ii) have been modified in such a way that they can be executed against JBossMQ or Messaging by setting up appropriate configuration files.

            The idea was to eventually have one directory of JMS tests, which would exercise only pure JMS functionality, and could be executed against either JMS implementation. At present, only the Messaging implementation is using these tests, as it is the default JMS provider in JBoss 5.

            I have a spreadsheet which I used to categorise the JBossMQ, if it is of any interest. There were some JBossMQ tests which are still in a pending state ( not yet included in the jbossmessaging package) as they test XA recovery, and XA recovery was not available in Messaging at the time.

            This list of tests from JBossMQ which were not carried over is:
            CleanTopicRemovalUnitTestCase
            ClientMonitorConnectionRaceUnitTestCase
            DestinationFullUnitTestCase
            HTTPConnectionUnitTestCase
            LargeMessageUnitTestCase
            NackWithRollbackUnitTestCase
            SelectorParserUnitTestCase
            SelectorSyntaxUnitTestCase
            UIL2ConnectionUnitTestCase
            UIL2InvocationLayerStressTestCase
            ExpiryDestinationTestCase
            HTTPJBossMQUnitTestCase
            ScheduledDeliveryUnitTestCase
            UIL2JBossMQUnitTestCase
            ReceiversImplStressTestCase
            ReceiversImplArrayListStressTestCase
            ReceiversImplLinkedListStressTestCase
            These all had JBossMQ depenedencies referenced in them. However, it may be that, for some of these tests, aside from some minor dependency on JBossMQ, a similar generic JMS test might want to be developed (e.g. LargeMessageUnitTestCase)

            • 3. Re: org.jboss.test.jbossmq.test cleanup in jboss5
              Scott Stark Master

              The UIL2* tests have been removed. most of thest tests should have analogs in the internal jbm testsuite, but are not really integration tests and could be dropped.

              • 4. Re: org.jboss.test.jbossmq.test cleanup in jboss5
                Scott Stark Master

                A problem I'm seeing with some test (org.jboss.test.jbossmessaging.test.MessageTypesUnitTestCase) is a failure to deploy the test jms destinations:

                2007-03-28 22:12:49,448 DEBUG [org.jboss.jms.server.destination.QueueService] Starting jboss.messaging.destination:service=Queue,name=testQueue
                2007-03-28 22:12:49,462 ERROR [org.jboss.jms.util.ExceptionUtil] Queue[null, name=testQueue] startService
                java.lang.ArrayIndexOutOfBoundsException: 10
                 at org.jboss.messaging.util.prioritylinkedlist.BasicPriorityLinkedList.addLast(BasicPriorityLinkedList.java:64)
                 at org.jboss.messaging.core.PagingChannelSupport.addFromRefInfo(PagingChannelSupport.java:546)
                 at org.jboss.messaging.core.PagingChannelSupport.doLoad(PagingChannelSupport.java:525)
                 at org.jboss.messaging.core.PagingChannelSupport.load(PagingChannelSupport.java:211)
                 at org.jboss.jms.server.destination.QueueService.startService(QueueService.java:86)
                 at org.jboss.system.ServiceMBeanSupport.jbossInternalStart(ServiceMBeanSupport.java:289)
                 at org.jboss.system.ServiceMBeanSupport.start(ServiceMBeanSupport.java:196)
                 at sun.reflect.GeneratedMethodAccessor66.invoke(Unknown Source)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                 at java.lang.reflect.Method.invoke(Method.java:585)
                 at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
                 at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
                 at org.jboss.mx.interceptor.AbstractInterceptor.invoke(AbstractInterceptor.java:138)
                 at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
                 at org.jboss.mx.interceptor.ModelMBeanOperationInterceptor.invoke(ModelMBeanOperationInterceptor.java:140)
                 at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
                 at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
                 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
                 at org.jboss.system.microcontainer.ServiceProxy.invoke(ServiceProxy.java:184)
                 at $Proxy0.start(Unknown Source)
                 at org.jboss.system.microcontainer.StartStopLifecycleAction.installAction(StartStopLifecycleAction.java:42)
                 at org.jboss.system.microcontainer.ServiceControllerContextAction.install(ServiceControllerContextAction.java:46)
                 at org.jboss.dependency.plugins.AbstractControllerContextActions.install(AbstractControllerContextActions.java:51)
                 at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:233)
                 at org.jboss.system.microcontainer.ServiceControllerContext.install(ServiceControllerContext.java:238)
                 at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:724)
                 at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:445)
                 at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:555)
                 at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:489)
                 at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:335)
                 at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:205)
                 at org.jboss.system.ServiceController.doChange(ServiceController.java:656)
                 at org.jboss.system.ServiceController.start(ServiceController.java:431)
                 at org.jboss.system.deployers.ServiceDeployer.start(ServiceDeployer.java:142)
                 at org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:103)
                 at org.jboss.system.deployers.ServiceDeployer.deploy(ServiceDeployer.java:46)
                 at org.jboss.deployers.plugins.deployers.helpers.AbstractSimpleRealDeployer.deploy(AbstractSimpleRealDeployer.java:56)
                 at org.jboss.deployers.plugins.deployer.AbstractSimpleDeployer.commitDeploy(AbstractSimpleDeployer.java:52)
                 at org.jboss.deployers.plugins.deployer.DeployerWrapper.commitDeploy(DeployerWrapper.java:170)
                 at org.jboss.deployers.plugins.deployment.MainDeployerImpl.commitDeploy(MainDeployerImpl.java:592)
                 at org.jboss.deployers.plugins.deployment.MainDeployerImpl.commitDeploy(MainDeployerImpl.java:603)
                 at org.jboss.deployers.plugins.deployment.MainDeployerImpl.process(MainDeployerImpl.java:476)
                 at org.jboss.deployers.plugins.deployment.MainDeployerImpl.process(MainDeployerImpl.java:406)
                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                 at java.lang.reflect.Method.invoke(Method.java:585)
                 at org.jboss.aop.joinpoint.MethodInvocation.invokeTarget(MethodInvocation.java:121)
                 at org.jboss.aop.joinpoint.MethodInvocation.invokeNext(MethodInvocation.java:110)
                 at org.jboss.profileservice.aop.MainDeployerAspect.process(MainDeployerAspect.java:53)
                 at org.jboss.aop.advice.org.jboss.profileservice.aop.MainDeployerAspect_z_process_1126829932.invoke(MainDeployerAspect_z_process_1126829932.java)
                 at org.jboss.aop.joinpoint.MethodInvocation.invokeNext(MethodInvocation.java:101)
                 at AOPContainerProxy$0.process(AOPContainerProxy$0.java)
                 at org.jboss.deployment.MainDeployer.deploy(MainDeployer.java:795)
                 at org.jboss.deployment.MainDeployer.redeploy(MainDeployer.java:570)
                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                 at java.lang.reflect.Method.invoke(Method.java:585)
                 at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
                 at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
                 at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
                 at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
                 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                 at java.lang.reflect.Method.invoke(Method.java:585)
                 at org.jboss.jmx.connector.invoker.InvokerAdaptorService.invoke(InvokerAdaptorService.java:266)
                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                 at java.lang.reflect.Method.invoke(Method.java:585)
                 at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
                 at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
                 at org.jboss.mx.interceptor.AbstractInterceptor.invoke(AbstractInterceptor.java:138)
                 at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
                 at org.jboss.mx.interceptor.ModelMBeanOperationInterceptor.invoke(ModelMBeanOperationInterceptor.java:140)
                 at org.jboss.jmx.connector.invoker.SerializableInterceptor.invoke(SerializableInterceptor.java:74)
                 at org.jboss.mx.server.Invocation.invoke(Invocation.java:90)
                 at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
                 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
                 at org.jboss.invocation.jrmp.server.JRMPProxyFactory.invoke(JRMPProxyFactory.java:179)
                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                 at java.lang.reflect.Method.invoke(Method.java:585)
                 at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
                 at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
                 at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
                 at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
                 at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
                 at org.jboss.invocation.jrmp.server.JRMPInvoker$MBeanServerAction.invoke(JRMPInvoker.java:815)
                 at org.jboss.invocation.jrmp.server.JRMPInvoker.invoke(JRMPInvoker.java:416)
                 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                 at java.lang.reflect.Method.invoke(Method.java:585)
                 at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:294)
                 at sun.rmi.transport.Transport$1.run(Transport.java:153)
                 at java.security.AccessController.doPrivileged(Native Method)
                 at sun.rmi.transport.Transport.serviceCall(Transport.java:149)
                 at sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:466)
                 at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:707)
                 at java.lang.Thread.run(Thread.java:595)