True, we are basically just testing JGroups functionality, but there is no harm ion having more tests.
BTW you could avoid the nasty private field inspection by subclassing ClusteredPersistenceServiceConfigFileJChannelFactory and adding an getter for the JChannel, this would be cleaner.
Anyway this is not critical for now.
Ok so I'm going to add other similar tests to check the rest of Brian's points. I don't want to use CPSCFJChannelFactory in the tests because it's a test-related object and I'd rather test the real thing. I could make DefaultClusteredPostOffice.syncChannel and asyncChannel fields protected, derive a test class from it exposing those fields and then use that class, but it looks like a lot of work for little payoff.
I'm adding -Djgroups.bind_addr=127.0.0.1 on places where we are starting JVMs on the testsuite, then we would use 127.0.0.1 as we used to do.
I couldn't find a way to open UDP on my wireless router, so I guess this would be better for our testing.
Errr.. Never mind... Sergey had already done the same exact change! :-)
Actuallly.. kind of funny Sergey's change was on the same line.. same spacing... It is kind of a simple change.. but I felt funny the same way!
I think Clebert invented the alter ego of Sergey, so he could receive a double salary. ;)