6 Replies Latest reply on May 9, 2008 6:06 AM by Tim Fox

    Do we need JournalStorageManager::ADD_MESSAGE?

    Clebert Suconic Master

      Do we really need ADD_MESSAGE on JournalStorageManager?

      ADD_MESSAGE are aways done on Journal.appendAddRecord or appendAddRecordTransactional. With that in hand when you have an ADD on the journal it can't be other thing but ADD_MESSAGE.

      I'm asking that because we are making an extra copy just to place the ADD_MESSAGE byte. We could eliminate it if we didn't need that.

      I would of course keep the bytes on ACKs and MessageCounter.