2 Replies Latest reply on Jun 12, 2008 1:18 PM by Andy Taylor

    RemotingConnectionImpl and Mina Dependency

    Andy Taylor Master

      I'm planning (in the process of) abstracting the Mina dependency out of RemotingServiceImpl.

      I will create a new Interface, 'Acceptor', that will handle anything that is transport specific. To start there will be 2 implementations 'MinaAcceptor' and 'INVMAcceptor' but obviously we'll have more once we implement HTTP, Servlet etc and it will also help once Trustin is ready to integrate Netty.

      The RemotingService will also now be able to handle multiple acceptors.

        • 1. Re: RemotingConnectionImpl and Mina Dependency
          Tim Fox Master

          Looking good so far.

          A few observations:

          The core.remoting.impl.mina package contains:

          CleanupNotifier - this is generic core not MINA only?
          ClientKeepAliveFactory - do we need this - I don't see the point?
          ServerKeepAliveFactory - do we need this?
          MessagingCodec - this should be generic too?

          Also we can probably rename NIOConnector and NIOSession to something more generic since they're not specific to NIO

          • 2. Re: RemotingConnectionImpl and Mina Dependency
            Andy Taylor Master

             

            CleanupNotifier - this is generic core not MINA only?

            yep you're right i'll move it.
            ClientKeepAliveFactory - do we need this - I don't see the point?
            ServerKeepAliveFactory - do we need this?

            At the minute they are their really just for test purposes. i'll remove them when ive added different tests using mock's
            MessagingCodec - this should be generic too?

            I agree, i'll sort this.
            Also we can probably rename NIOConnector and NIOSession to something more generic since they're not specific to NIO


            I'll rename these to RemotingConnector/Session