This content has been marked as final.
Show 2 replies
-
1. Re: RemotingConnectionImpl and Mina Dependency
timfox Jun 12, 2008 12:30 PM (in response to ataylor)Looking good so far.
A few observations:
The core.remoting.impl.mina package contains:
CleanupNotifier - this is generic core not MINA only?
ClientKeepAliveFactory - do we need this - I don't see the point?
ServerKeepAliveFactory - do we need this?
MessagingCodec - this should be generic too?
Also we can probably rename NIOConnector and NIOSession to something more generic since they're not specific to NIO -
2. Re: RemotingConnectionImpl and Mina Dependency
ataylor Jun 12, 2008 1:18 PM (in response to ataylor)CleanupNotifier - this is generic core not MINA only?
yep you're right i'll move it.ClientKeepAliveFactory - do we need this - I don't see the point?
ServerKeepAliveFactory - do we need this?
At the minute they are their really just for test purposes. i'll remove them when ive added different tests using mock'sMessagingCodec - this should be generic too?
I agree, i'll sort this.Also we can probably rename NIOConnector and NIOSession to something more generic since they're not specific to NIO
I'll rename these to RemotingConnector/Session