JBossDeveloper

 

"timfox" wrote:
Also:

from QueueImpl
public QueueSettings getSettings()
 {
 return this.settings;
 }

This should be unnecessary since the queue settings is only used in the code to get the max-size-bytes which should have been removed (we discussed this).

Yeah... that will go away.

It is still there because places like SessionQueueQueryResponse and Management are still referring to max-size.

I will remove the setting as soon as those uses to MaxSize are removed.

SessionQueueQueryResponse is probably being changed by Andy on his Branch and I wanted to avoid too many changes there ATM on this single huge commit.

 

"clebert.suconic@jboss.com" wrote:

- I still want to change journal reload to use a FileChannel instead of loading the whole file in memory. Maybe this will be done as part of the journal optimization task later.

This is actually not viable.

Because the way we are validating holes, transaction health and other things. We move a lot around the buffer to make sure the register being read is valid, that there are not holes and other things like that.

Because of that it is not possible to replace the Buffer by a streaming, as reading those files without a Buffer would be too costly.

I've done a quick prototype and the reading time was prohibitive.

I will try to improve how the memory is read by some other optimization. (Maybe reusing the same buffer along all the files, what is quite possible).