6 Replies Latest reply on Sep 22, 2008 1:14 PM by Clebert Suconic

    Differences in config between eap 43 and as 5

    Tim Fox Master

      I did a

      diff -r AS5/etc EAP4/etc > diffs2.txt
      


      And I'm seeing quite a few differences.

      AFAICT the only differences should be related to differences in JBoss remoting config between 2.2.2.SP8 and 2.4.0, but that doesn't seem to be the case.

      The configs should be merged so that's the only difference.

        • 1. Re: Differences in config between eap 43 and as 5
          Clebert Suconic Master

           

          "Tim Fox" wrote:
          AFAICT the only differences should be related to differences in JBoss remoting config


          There are more difference you should take in account:

          - The JGroups config should be also different. JBoss5 will use the ChannelFactory.
          - messaging-service.xml will be totally different on JBoss5. They have a different SecurityMetadataStore. So, be careful with integration on JBoss5.
          - Soon JBossRemoting will be also different as the BindingManager is now based on property-substitution for the ports and not any more on that sausage-like XML.

          • 2. Re: Differences in config between eap 43 and as 5
            Tim Fox Master

             

            "clebert.suconic@jboss.com" wrote:

            - The JGroups config should be also different. JBoss5 will use the ChannelFactory.


            Ok, that's a couple of lines difference


            - messaging-service.xml will be totally different on JBoss5. They have a different SecurityMetadataStore.


            No, it shouldn't be totally different. Just a few lines different on security store config



            - Soon JBossRemoting will be also different as the BindingManager is now based on property-substitution for the ports and not any more on that sausage-like XML.


            This is not relevant to the discussion - we are talking about differences in *our source tree* not some other differences in jboss 5 source tree.

            So... there should just be a few lines different, but i am seeing 2700 lines diff in the diff.

            Most of that is probably whitespace or comments, but it should be merged.

            • 3. Re: Differences in config between eap 43 and as 5
              Clebert Suconic Master

              When you talked about merging, I thought you were referring to having only one file between AS5 and EAP.

              At the moment (unless we make few changes) we need two versions for the reasons I pointed out.

              We can of course minimize those differences.

              • 4. Re: Differences in config between eap 43 and as 5
                Tim Fox Master

                There should only be a difference where there really needs to be a real difference. Any other differences due to whitespace, formatting, comments etc should be made the same, otherwise it's going to be harder to maintain

                • 5. Re: Differences in config between eap 43 and as 5
                  Clebert Suconic Master

                  I want to create a generic directory under integration where the files that don't have any change will be placed.

                  /integration/generic


                  Later, I will need to change the bisocket configuration as the following:


                  <attribute name="socket.check_connection" isParam="true">false</attribute>
                   <attribute name="serverBindAddress">${jboss.bind.address}</attribute>
                   <attribute name="serverBindPort">${jbm.bisocket.port:4457}</attribute>
                   <attribute name="clientSocketClass" isParam="true">org.jboss.jms.client.remoting.ClientSocketWrapper</attribute>
                  




                  That config would also make the EAP, and that shouldn't cause any config incompatibilities.

                  Tim, do you see a problem with any of this?

                  • 6. Re: Differences in config between eap 43 and as 5
                    Clebert Suconic Master

                    Ok.. I kept the /integration/AS5 and /integration/EAP as they are now.


                    and the diffs are fixed.