JBossDeveloper

Ok, forget the comment about queues and wilcards, but the bottom line is allowable destinations are only used if checkAllowable = true.

"ataylor" wrote:

We = ?

There is certainly no obligation in core that allowable destinations are always populated.

I meant JMSServerManager when it deploys a topic.

It's pretty simple: You're assuming allowable destinations are always populated, but that's not a valid assumption.

Currently your assumption only holds in JMS world.

"ataylor" wrote:
[ At a core level can we not just specify that the destination always needs adding.

"ataylor" wrote:

Ok so this means either creating all the possible combinations, which is how it works now.
Or checking for matching wildcard mappings on send, which will have an overhead.

How about a variation on the caching approach?

The old caching approach that we discounted involved evaluating the routing address against all wildcards once to get the matching list, then caching the list for subsequent lookups.

The problem with the approach was that if a new match was added you had to invalidate the cache, so the next lookup would re-evaluate all matches. If a lot of new queues were being added frequently (as is often the case), then this would cause a lot of re-evaluation and slowness.

We could be a bit cleverer, and not invalidate the entire cache very time a new wildcard queue is added, but just evaluate the new match and add it to the cache.

If a match is removed from the post office then we could just look in the cache for each routing address and remove it from there.

Sounds about right

Here's a very simple test which causes the WildcardAddressManager to crash:

 AddressManager am = new WildcardAddressManager();

 Binding binding1 = new MyBinding();

 am.addMapping(new SimpleString("a.b.c.d.e.f.g.h.i.j.k.l.m.n.*"), binding1);

 Bindings bindings = am.getBindings(new SimpleString("a.b.c"));

 assertTrue(bindings.getBindings().isEmpty());

Here's another basic test that fails

 AddressManager am = new WildcardAddressManager();

 Binding binding1 = new MyBinding();

 am.addMapping(new SimpleString("a.b.*"), binding1);

 Bindings bindings = am.getBindings(new SimpleString("a.b.c"));

 assertTrue(bindings.getBindings().contains(binding1));

 Binding binding2 = new MyBinding();

 am.addMapping(new SimpleString("a.*"), binding2);

 bindings = am.getBindings(new SimpleString("a.b.c"));

 assertTrue(bindings.getBindings().contains(binding1));

 assertTrue(bindings.getBindings().contains(binding2));