1 Reply Latest reply on Mar 31, 2009 12:01 PM by Clebert Suconic

    Excluded failover tests

    Tim Fox Master

      I was puzzled that the failover tests weren't running on Hudson. On investigation I found this, committed about a week ago:

      Modified: trunk/build-messaging.xml
      ===================================================================
      --- trunk/build-messaging.xml 2009-03-23 16:02:12 UTC (rev 6142)
      +++ trunk/build-messaging.xml 2009-03-23 16:10:07 UTC (rev 6143)
      @@ -1145,7 +1145,7 @@
       <antcall inheritall="true" inheritrefs="true" target="tests">
       <param name="tests.param" value="**/org/jboss/messaging/tests/unit/**/*${test-mask}.class"/>
       <!-- if tests.validate.error is defined, it will fail the build in case of any test failure -->
      - <param name="tests.validate.error" value="Defined!"/>
      + <!-- <param name="tests.validate.error" value="Defined!"/> -->
       </antcall>
       </target>
      
      @@ -1191,7 +1191,7 @@
       <formatter type="plain" usefile="${junit.formatter.usefile}"/>
       <fileset dir="${test.classes.dir}">
       <include name="${tests.param}"/>
      - <exclude name="**/LargeMessageMultiThreadFailoverTest.class" />
      + <exclude name="**/*Failover*.class" />
       </fileset>
       </batchtest>
       </junit>
      


      :(

      Please guys, be more careful. We have had too many cases of comment out tests/exclusions/other stuff making it into svn from your local workspaces.

        • 1. Re: Excluded failover tests
          Clebert Suconic Master

          Just my 2 cents...

          In a perfect world, we should run all the testsuite, but if you hack the excludes for any reason.. it's better to do it in a different target.... like you could create something like "MyTests" ... so if you accidentally commit the build.xml, at least it won't affect hudson.