8 Replies Latest reply on Apr 27, 2009 7:13 AM by Clebert Suconic

    AS 5 Profiles bindings

    Jeff Mesnil Master

      I'm currently refactoring the creation of JBoss AS 5 profiles for JBoss Messaging.

      I'm not sure our current default profile ("jbm2_default" based on JBoss AS 5 "default") is correct.
      In AS/config/default/jbm-configuration, the port used by Netty/TCP is set to ${jbm.remoting.netty.port}. I guess it should be configured using JBoss AS 5 service binding manager.

      However, when I look into Branch_5_x, JBM2 port are only declared on server/src/etc/conf/all/bootstrap/bindings.xml. There is no such bindings.xml file for the default profile.
      When I build JBoss AS 5, its default profile does not contains JBM2 ports definition in its bindings.xml.

      Where does the default profile's bindings.xml come from in the source?
      Should we also define JBM2 ports in it or should jbm2_default profiles's port be hard-coded in our configs?

        • 1. Re: AS 5 Profiles bindings
          Tim Fox Master

          We should add our ports in the non clustered AS service bindings too.

          BTW, can we not use the name jbm2_default for our non clustered config? I always found the name "default" confusing (and AS specific).

          Can we just use jbm2_non_clustered? this is more explicit as to what it is.

          So we end up (as discussed on the previous thread) with:

          src/config/jboss-as/non-clustered
          src/config/jboss-as/clustered
          src/config/stand-alone/non-clustered
          src/config/stand-alone/clustered

          • 2. Re: AS 5 Profiles bindings
            Jeff Mesnil Master

             

            "timfox" wrote:
            We should add our ports in the non clustered AS service bindings too.


            Ok, I'll add them.

            "timfox" wrote:

            BTW, can we not use the name jbm2_default for our non clustered config? I always found the name "default" confusing (and AS specific).

            Can we just use jbm2_non_clustered? this is more explicit as to what it is.


            I'm not sure about this one.
            the AS 5 profiles are AS-specific. I'd find clearer to name it "default-with-jbm2", meaning it is the AS 5 *default* profile with JBM 2 (instead of the messaging version installed by default).
            People wanting to use JBM2 with AS 5 will likely understand better AS-centric names.

            In the same way, "all-with-jbm2" may make more sense (or "all-with-jbm2-clustered" to insist that it's a clustered JBM2 config)



            • 3. Re: AS 5 Profiles bindings
              Tim Fox Master

               

              "jmesnil" wrote:


              I'm not sure about this one.
              the AS 5 profiles are AS-specific. I'd find clearer to name it "default-with-jbm2", meaning it is the AS 5 *default* profile with JBM 2 (instead of the messaging version installed by default).
              People wanting to use JBM2 with AS 5 will likely understand better AS-centric names.

              In the same way, "all-with-jbm2" may make more sense (or "all-with-jbm2-clustered" to insist that it's a clustered JBM2 config)



              The problem is, it's perfectly ok to deploy the non clustered JBM config in the JBM all configuration, so we shouldn't link the jbm config file name to any one particular AS configuration.



              • 4. Re: AS 5 Profiles bindings
                Tim Fox Master

                Maybe I'm getting confused here.

                Are you talking about the AS profile name, or our config names?

                Agreed the *profiles* in AS should be called something like all_with_jbm2 but the config directory names should not reference the AS profile names, i.e.

                src/config/jboss-as/clustered

                NOT: src/config/jboss-as/all

                • 5. Re: AS 5 Profiles bindings
                  Jeff Mesnil Master

                  yes, I was talking about the profile names.

                  To recap, our *config* will be:
                  src/config/stand-alone/clustered
                  src/config/stand-alone/non-clustered
                  src/config/jboss-as/clustered
                  src/config/jboss-as/non-clustered

                  and we will create 2 *AS 5 profiles*:
                  default-with-jbm2 (using jboss-as/non-clustered config)
                  all-with-jbm2 (using jboss-as/clustered config)

                  do yo agree?

                  • 7. Re: AS 5 Profiles bindings
                    Clebert Suconic Master

                     

                    "jmesnil" wrote:

                    I'm not sure our current default profile ("jbm2_default" based on JBoss AS 5 "default") is correct.
                    In AS/config/default/jbm-configuration, the port used by Netty/TCP is set to ${jbm.remoting.netty.port}. I guess it should be configured using JBoss AS 5 service binding manager.


                    Look at bindings.xml under /jboss/SERVER/conf/bootstrap. jboss-remoting.netty is defined on that port. To use the ServiceBindingManager directly we would need the port to be specified by a bean on beans.xml. There is a service that defines properties on that file.

                    • 8. Re: AS 5 Profiles bindings
                      Clebert Suconic Master


                      We should add our ports in the non clustered AS service bindings too.


                      We have our ports defined now, even on the Non-JBM profile. Even if you add JBM by hand you will have the ports defined.


                      I have defined 5445 for Netty and 5446 for Netty-ssl.