1 Reply Latest reply on Jul 21, 2009 12:18 PM by Clebert Suconic

    PagingManager methods

    Tim Fox Master

       

       // FIXME - why are these methods still on PagingManager???
       // The current code is doing a lookup every time through this class just to call page store!!
       boolean page(ServerMessage message, boolean duplicateDetection) throws Exception;
      
       /**
       * Page, only if destination is in page mode.
       * @param message
       * @return false if destination is not on page mode
       */
      
       // FIXME - why are these methods still on PagingManager???
       // The current code is doing a lookup every time through this class just to call page store!!
       boolean page(ServerMessage message, long transactionId, boolean duplicateDetection) throws Exception;
      


      Aren't these methods supposed to have been removed?

        • 1. Re: PagingManager methods
          Clebert Suconic Master

          The two places calling page, don't have any direct relationship to an Address.

          Because of that, each place would be doing exactly what is encapsulated withing PagingManager, and I didn' t remove it because of that.

          As the hashMap operation is needed, I would just keep it properly encpasulated in PagingManager, unless we find a way to proper cache the PagingStore.