This is for the following jsr-88 issue:
http://jira.jboss.com/jira/browse/JBAS-1998
One place for adding a notion of a deployment type is to the MainDeployer itself. I don't think it really belongs in the the SubDeployer interface. Another candiate location is the org.jboss.management.j2ee.LocalJBossServerDomain jsr-77 mapping service where the deployers are registered for creation of the managment mbeans:
<mbean code="org.jboss.management.j2ee.LocalJBossServerDomain"
name="jboss.management.local:j2eeType=J2EEDomain,name=Manager">
<attribute name="MainDeployer">jboss.system:service=MainDeployer</attribute>
<attribute name="SARDeployer">jboss.system:service=ServiceDeployer</attribute>
<attribute name="EARDeployer">jboss.j2ee:service=EARDeployer</attribute>
<attribute name="EJBDeployer">jboss.ejb:service=EJBDeployer</attribute>
<attribute name="RARDeployer">jboss.jca:service=RARDeployer</attribute>
<attribute name="CMDeployer">jboss.jca:service=ConnectionFactoryDeployer</attribute>
<attribute name="WARDeployer">jboss.web:service=WebServer</attribute>
<attribute name="MailService">jboss:service=Mail</attribute>
<attribute name="JMSService">jboss.mq:service=DestinationManager</attribute>
<attribute name="JNDIService">jboss:service=Naming</attribute>
<attribute name="JTAService">jboss:service=TransactionManager</attribute>
<attribute name="UserTransactionService">jboss:service=ClientUserTransaction</attribute>
<attribute name="RMI_IIOPService">jboss:service=CorbaORB</attribute>
</mbean>
If the categorization of a deployment into a module type was done here, it would have to be as a side-effect which resulted in the setting of a module type field in the DeploymentInfo, or data in the DeploymentInfo.context.
The other alternative is that the SerializableDeploymentInfo.deployer ObjectName is mapped to a module type by the jsr88 layer by having this layer query the LocalJBossServerDomain for the key j2ee deployers. This is the approach I favor.
Do we really need a module type classification in the SerializableDeploymentInfo?
