Hi Jean,

The code freeze for AS 5.1.0.GA is tomorrow and I'm on vacation, so the following is significantly colored by that. I can think about this more in a couple weeks when I get back, but once 5.1.0.GA is done there may not be a 5.2 as we move on to AS 6.

For AS 6 please open a JIRA to have another look at this design. I'm not comfortable with all these protected methods.

"deruelle_jean" wrote:

* initSnapshotManager to be made protected so that it can be overriden (so that we can set our own converged snapshotManager)

Done.

* getSnapshotManager() and setSnapshotManager() public methods or snapShotManager_ field to be made protected

Added a protected getter/setter. I don't want it public.

* installValves and installValve methods to be made protected so that they can be overriden (we need that to install our custom JVMRouteValve)

Done.

* Ideally, methods such as start/stopEmbedded and UnEmbedded and the methods they use internally should be made protected too

I renamed initCacheProxy() to initDistributedCacheManager() and made it protected. Also made initClusteredSessionNotificationPolicy() and initializeUnloadedSessions() protected.

Also added protected void startExtensions() and stopExtensions() which are a hook into the start/stop process for subclasses.

I do not want to expose startUnembedded. That is to support running in standalone Tomcat, which was a JIRA started in 2005 and never officially finished, not significantly tested in years etc. I don't want to make it part of this API. Does Mobicents run in standalone Tomcat?

Would prefer not exposing startEmbedded either.

If you *really need* start(Un)Embedded exposed, go ahead on Monday, but assume that there would be some change in AS 6; i.e. you and I will redesign this. And please be extremely careful as it's the code cutoff. :)

AbstractJBossCacheService

* make the storeSessionOwners protected so that we can reuse it

Feel free to make this a protected static method. However this change will not be in AS 5.1.0.GA as this would require a component update and we are past the deadline for component updates. A later Mobicents release of course could replace this jar with a later version. Which is why it's a separate jar. :)

IntervalSnapshotManager

* make the fields protected

This is a simple enough class, and you now have the hooks to install whatever SnapshotManager you like, so please just keep your own version.


The above changes are svn r88986 in Branch_5_x. Not ported to trunk yet.