Here I am, replying to myself. :)
A similar problem as the one at the top of my last message.
AspectXmlLoader.java line 262
"group.trim().equals("")" --> "attr.trim().equals("")"
Are these actually bugs? Is there something that I'm missing here, and completely screwing up by "fixing" these? Is everyone that reads these as clueless on some of this stuph as I am, or are my questions not worth answering they are so trivial? :)
your fixes are not correct. This is iterating over Method calls, not Constructor calls. What are you actually seeing as the problem?
I can't remember what problems I was having with CallerExprEditor. It gave me a ClassCastException near the beginning I think, because it was passed in a CtConstructor and you cast it to a CtMethod. The alternate solution was to return if you get a CtConstructor.
(I imagine you discuss the other problem in a thread above, I'll go there.)
You didn't discuss the other problem above. My bad :)
There are about 3 places in AspectXmlLoader.java (one is line 262, others are unfortunately listed at home, not where I am) where it says group.trim().equal(""), and although I could definitely be wrong, I think it means attr.trim().equals(""). I believe there was an NPE at that point with the code as it was.
If you have another solution, I'm all for it. There have been several times when I thought I found bugs, when really, no, I was just wrong :)
I fixed these problems within our source control system.
You can access our control system here:
After you checkout:
$ cd jboss-head/aop
$ build.sh (or build.bat if you're on Windows)
$build.sh dist will build a distribution with javadoc, all jars and such.