From JBAOP-80

AOP should expose itself through the JoinPointFactory
in particular the invocations should implement the JoinPoint interface

Obviously it does not work the way it is meant to at the moment, but can the AOPConstructorJoinPoint not instantiate the ConstructorInvocation?

"adrian@jboss.org" wrote:

Advised + Instance specific metadata = Instance Advised POJO

I have added some tests for JBAOP-227 to test the decision matrix, they are under org.jboss.test.microcontainer.matrix in the aop-mc-int module.

As mentioned previously I have

Advised + Instance specific metadata -> Instance advised Proxy

(not instance advised POJO) since metadata could cause an introduction to happen.

If this is not ok, I could perhaps have the proxy factory check if the metadata in fact does cause extra interface introductions and create a proxy as needed? Your call :-)

I've got a weird scenario taking place in the inheritance tests for JBAOP-229. Basically if I do:

-aop.xml:

 <bind pointcut="execution(* @org.jboss.test.microcontainer.support.Test->*(..))">
 <interceptor-ref name="org.jboss.test.microcontainer.matrix.TestInterceptor"/>
 </bind>

 <bean name="ProxiedChild" class="org.jboss.test.microcontainer.matrix.Child">
 <annotation name="org.jboss.test.microcontainer.support.Test"/>
 </bean>

public class Child extends Base
{
 public static boolean childInvoked;
 public void childOnly()
 {
 childInvoked = true;
 }

 public void baseOverridden()
 {
 childInvoked = true;
 }
}

public class Base
{
 public static boolean baseInvoked;
 public void baseOnly()
 {
 baseInvoked = true;
 }

 public void baseOverridden()
 {
 baseInvoked = true;
 }

 public void setProperty(int i)
 {
 baseInvoked = true;
 }
}

execution(* @org.jboss.test.microcontainer.support.Test->*(..))

 <introduction class="@org.jboss.test.microcontainer.support.Test">
 <interfaces>org.jboss.test.microcontainer.matrix.ChildInterface</interfaces>
 </introduction>

 <bind pointcut="execution(* $instanceof{org.jboss.test.microcontainer.matrix.ChildInterface}->$implements{org.jboss.test.microcontainer.matrix.ChildInterface}(..))">
 <interceptor-ref name="org.jboss.test.microcontainer.matrix.TestInterceptor"/>
 </bind>

public interface ChildInterface
{
 void childOnly();
 void baseOverridden();
}

I get the opposite scenario from with a real annotation

@Test
public class Child extends Base
{
 public static boolean childInvoked;
 public void childOnly()
 {
 childInvoked = true;
 }

 public void baseOverridden()
 {
 childInvoked = true;
 }
}

execution(* @org.jboss.test.microcontainer.support.Test->*(..))

OK,

The problem is the "behave the same" bit. With the current weaving mode that is used by default, the proxies do not behave like AOP as is stands right now. But with the AOP 2 weaving mode, AOP will behave like the the proxies.

A major feature of AOP 2, along with the full-blown per instance API, is the ability to specify interceptors for inherited methods.

There are still a few issues left before it is possible to make the new weaving mode the default. My understanding is that they should behave the same for no other reason than that they should be interchangable?

I've got all the pure aop stuff passing now using the new weaving mode (http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3947214#3947214)

I still need to resolve creating an instance proxy for an already advised class using the new weaving mode before I can do the switch and add to these tests as outlined above.